From patchwork Fri Aug 4 10:39:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9880973 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B0B206031B for ; Fri, 4 Aug 2017 10:40:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A0C96289CC for ; Fri, 4 Aug 2017 10:40:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 95AA9289D1; Fri, 4 Aug 2017 10:40:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7C496289D4 for ; Fri, 4 Aug 2017 10:40:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8AD256E3A3; Fri, 4 Aug 2017 10:39:59 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-yw0-x244.google.com (mail-yw0-x244.google.com [IPv6:2607:f8b0:4002:c05::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2D3F6E3A3; Fri, 4 Aug 2017 10:39:58 +0000 (UTC) Received: by mail-yw0-x244.google.com with SMTP id s143so719455ywg.4; Fri, 04 Aug 2017 03:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=DClZpTm7s3qrBirFPHPlbiGe5fSHRq1JswECxcBbHR4=; b=YCAdH9iz/iyXaFq5do7nejQextEMHW+1a2UrMGuOHQ1RDCahdMFOf4VdY7WiPVxp/o 6JgJ3So6zC7jcnRF6j4HPgSSTzS3/+9KO7Q9PirYwzopfJm0icQrkcQJikQB+Qr0880Q AXL+v5/dG4oAMkNUgtHETJ5kDYQD6hNMOeInPLD1Fzd1EGxmiitbMMRb2Ig/MqTmJTad u+1gtkLajuynbJe98Tvr5IhxL5+zIzA51QkhWzwu4msIKffn5UEln5ldq7t4+NoGVTI/ QvIqwfhxYpwJrd9IZMHM/mVDrHQYVWXegW3SAD5SSeXudn6thf5jWXYQ/+/zhnZbcxqh pAOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=DClZpTm7s3qrBirFPHPlbiGe5fSHRq1JswECxcBbHR4=; b=CBocByNwaVy9QWb7TbmDGEgLtTc5PAF9WH1Ee1ldiZCG+htwHWu8xOKGJwPtvEiHoi PnhCCzDteUSxuWlF7aipzMiPcGdvm8/DjbkUYscOP0l7hrJpy6ecJKEXXXzmWhxThiYt lKskmkWaR09FJOkhxm5pS2DtAAPM02ylM+Q1zlHLaayEKWcuggeIWaCA1BEa3c5vGQmT 8U5NHi/eVTHVjBBUXvpEPZrxyyPZ8OGTa8JIvVuS6pVsXjo8TWZq7S3z+jiRwyFZ6RHL Ur3rx9/kDMxwVlcip/5Cjf1HOESicJpllMY0HyDQYkszq7O0zq84H62rPYOKCQkrwQGr BENQ== X-Gm-Message-State: AIVw110YoLqcyJfzo2VgfbJkmOxKY2adg6vaAHVRiG8fExYPw7XDAeDi 9bct4dhU1Qi+n6vgnPQUyQ== X-Received: by 10.129.174.6 with SMTP id m6mr1416770ywh.255.1501843197791; Fri, 04 Aug 2017 03:39:57 -0700 (PDT) Received: from [10.17.129.40] ([223.31.70.102]) by smtp.gmail.com with ESMTPSA id d186sm413873ywc.48.2017.08.04.03.39.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Aug 2017 03:39:57 -0700 (PDT) To: Lionel Landwerlin , daniel.vetter@intel.com, jani.nikula@linux.intel.com, airlied@linux.ie References: <1501823016-6779-1-git-send-email-arvind.yadav.cs@gmail.com> <64fe44aa-7827-e81e-835f-c50a8cbe4021@intel.com> <472019e3-ef75-4041-0717-f6eeec178214@gmail.com> <99e06ee3-ece3-90d6-fd54-ea6789d991f9@intel.com> From: Arvind Yadav Message-ID: <2a606fe4-a74c-489a-5783-240be704bdb6@gmail.com> Date: Fri, 4 Aug 2017 16:09:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <99e06ee3-ece3-90d6-fd54-ea6789d991f9@intel.com> Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 00/11] constify i915 attribute_group structures. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP On Friday 04 August 2017 04:04 PM, Lionel Landwerlin wrote: > On 04/08/17 11:22, Arvind Yadav wrote: >> Hi Lionel, >> >> >> On Friday 04 August 2017 02:33 PM, Lionel Landwerlin wrote: >>> Hi Arwind, >>> >>> These files were generated by a script maintained in this repository >>> : >>> https://github.com/rib/gputop/blob/master/scripts/i915-perf-kernelgen.py >>> >>> It would best to update this script first to make sure future >>> platforms get the fixes too. >>> >>> Some changes have just been merged, deleted most configs but the >>> test ones. >>> You'll need to update your series. >>> >> I have done the changes. Please review it. :) Shared patch is >> 0001-i915-perf-kernelgen.py-constify-attribute_group-stru.patch. > > Hm... Where is it? (I can't see it on the mailing list nor attached) > The best would be to submit a PR on the github project directly. > I have push directly on github project. I have send patch to you. Is there any different way to send mail.? Changes are looks like this. --- scripts/i915-perf-kernelgen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) c(".attrs = attrs_" + perf_name_lc + ",") --- >> >>> Otherwise it looks like a good change. >>> >>> Thanks, >>> >>> - >>> Lionel >>> >>> On 04/08/17 06:03, Arvind Yadav wrote: >>>> attribute_group are not supposed to change at runtime. All functions >>>> working with attribute_group provided by work with >>>> const attribute_group. So mark the non-const structs as const. >>>> >>>> Arvind Yadav (11): >>>> [PATCH 01/11] drm: i915: i915_oa_kblgt2: constify >>>> attribute_group structures. >>>> [PATCH 02/11] drm: i915: i915_oa_bdw: constify attribute_group >>>> structures. >>>> [PATCH 03/11] drm: i915: i915_oa_bxt: constify attribute_group >>>> structures. >>>> [PATCH 04/11] drm: i915: i915_oa_chv: constify attribute_group >>>> structures. >>>> [PATCH 05/11] drm: i915: i915_oa_glk: constify attribute_group >>>> structures. >>>> [PATCH 06/11] drm: i915: i915_oa_hsw: constify attribute_group >>>> structures. >>>> [PATCH 07/11] drm: i915: i915_oa_kblgt3: constify >>>> attribute_group structures. >>>> [PATCH 08/11] drm: i915: i915_oa_sklgt2: constify >>>> attribute_group structures. >>>> [PATCH 09/11] drm: i915: i915_oa_sklgt3: constify >>>> attribute_group structures. >>>> [PATCH 10/11] drm: i915: i915_oa_sklgt4: constify >>>> attribute_group structures. >>>> [PATCH 11/11] drm: i915: i915_sysfs: constify attribute_group >>>> structures. >>>> >>>> drivers/gpu/drm/i915/i915_oa_bdw.c | 44 >>>> +++++++++++++++++------------------ >>>> drivers/gpu/drm/i915/i915_oa_bxt.c | 30 ++++++++++++------------ >>>> drivers/gpu/drm/i915/i915_oa_chv.c | 28 +++++++++++----------- >>>> drivers/gpu/drm/i915/i915_oa_glk.c | 30 ++++++++++++------------ >>>> drivers/gpu/drm/i915/i915_oa_hsw.c | 12 +++++----- >>>> drivers/gpu/drm/i915/i915_oa_kblgt2.c | 36 >>>> ++++++++++++++-------------- >>>> drivers/gpu/drm/i915/i915_oa_kblgt3.c | 36 >>>> ++++++++++++++-------------- >>>> drivers/gpu/drm/i915/i915_oa_sklgt2.c | 36 >>>> ++++++++++++++-------------- >>>> drivers/gpu/drm/i915/i915_oa_sklgt3.c | 36 >>>> ++++++++++++++-------------- >>>> drivers/gpu/drm/i915/i915_oa_sklgt4.c | 36 >>>> ++++++++++++++-------------- >>>> drivers/gpu/drm/i915/i915_sysfs.c | 6 ++--- >>>> 11 files changed, 165 insertions(+), 165 deletions(-) >>>> >>> >> ~arvind >> > diff --git a/scripts/i915-perf-kernelgen. py b/scripts/i915-perf-kernelgen.py index 7178f47..7633624 100755 --- a/scripts/i915-perf-kernelgen.py +++ b/scripts/i915-perf-kernelgen.py @@ -382,7 +382,7 @@ def output_sysfs_code(sets): c("};") c("\n") - c("static struct attribute_group group_" + perf_name_lc + " = {") + c("static const struct attribute_group group_" + perf_name_lc + " = {") c.indent(8) c(".name = \"" + metric_set['guid'] + "\",")