diff mbox

[i-g-t] tests/kms: increase max threshold time for edid read

Message ID 1501870998-11047-1-git-send-email-clinton.a.taylor@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Taylor, Clinton A Aug. 4, 2017, 6:23 p.m. UTC 
From: Clint Taylor <clinton.a.taylor@intel.com>

Current 50ms max threshold timing for an EDID read is very close to the
actual time for a 2 block HDMI EDID read of 48ms. Any delay like a clock
stretch by the EDID eeprom will cause this test to fail. A 4 block HDMI
EDID read takes approximately 88ms under nominal conditions, making the max
threshold 95ms will allow this test to pass regardless of monitor attached.

Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
---
 tests/kms_sysfs_edid_timing.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Daniel Vetter Aug. 7, 2017, 4:20 p.m. UTC | #1 
On Fri, Aug 04, 2017 at 11:23:18AM -0700, clinton.a.taylor@intel.com wrote:
> From: Clint Taylor <clinton.a.taylor@intel.com>
> 
> Current 50ms max threshold timing for an EDID read is very close to the
> actual time for a 2 block HDMI EDID read of 48ms. Any delay like a clock
> stretch by the EDID eeprom will cause this test to fail. A 4 block HDMI
> EDID read takes approximately 88ms under nominal conditions, making the max
> threshold 95ms will allow this test to pass regardless of monitor attached.
> 
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>

Per internal mail, this needs to be runtime adjusted to fit the EDID we're
reading. Maybe 30ms per edid block.

Thanks, Daniel

> ---
>  tests/kms_sysfs_edid_timing.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 1201388..b45e080 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -27,14 +27,14 @@
>  #include <sys/stat.h>
>  
>  #define THRESHOLD_PER_CONNECTOR	10
> -#define THRESHOLD_TOTAL		50
> +#define THRESHOLD_TOTAL		95
>  #define CHECK_TIMES		15
>  
>  IGT_TEST_DESCRIPTION("This check the time we take to read the content of all "
>  		     "the possible connectors. Without the edid -ENXIO patch "
>  		     "(http://permalink.gmane.org/gmane.comp.video.dri.devel/62083), "
> -		     "we sometimes take a *really* long time. "
> -		     "So let's just check for some reasonable timing here");
> +		     "we sometimes take a *really* long time. So let's just "
> +		     "check an approximate HDMI 4 block edid read timing here");
>  
>  
>  igt_simple_main
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Marta Lofstedt Aug. 8, 2017, 7:51 a.m. UTC | #2 
Thanks Clinton!

If you add:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100047

You have my Rb.
/Marta

> -----Original Message-----

> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf

> Of clinton.a.taylor@intel.com

> Sent: Friday, August 4, 2017 9:23 PM

> To: intel-gfx@lists.freedesktop.org

> Subject: [Intel-gfx] [PATCH i-g-t] tests/kms: increase max threshold time for

> edid read

> 

> From: Clint Taylor <clinton.a.taylor@intel.com>

> 

> Current 50ms max threshold timing for an EDID read is very close to the

> actual time for a 2 block HDMI EDID read of 48ms. Any delay like a clock

> stretch by the EDID eeprom will cause this test to fail. A 4 block HDMI EDID

> read takes approximately 88ms under nominal conditions, making the max

> threshold 95ms will allow this test to pass regardless of monitor attached.

> 

> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>

> ---

>  tests/kms_sysfs_edid_timing.c | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c

> index 1201388..b45e080 100644

> --- a/tests/kms_sysfs_edid_timing.c

> +++ b/tests/kms_sysfs_edid_timing.c

> @@ -27,14 +27,14 @@

>  #include <sys/stat.h>

> 

>  #define THRESHOLD_PER_CONNECTOR	10

> -#define THRESHOLD_TOTAL		50

> +#define THRESHOLD_TOTAL		95

>  #define CHECK_TIMES		15

> 

>  IGT_TEST_DESCRIPTION("This check the time we take to read the content of

> all "

>  		     "the possible connectors. Without the edid -

> ENXIO patch "

> 

> "(http://permalink.gmane.org/gmane.comp.video.dri.devel/62083), "

> -		     "we sometimes take a *really* long time. "

> -		     "So let's just check for some reasonable

> timing here");

> +		     "we sometimes take a *really* long time. So

> let's just "

> +		     "check an approximate HDMI 4 block edid

> read timing here");

> 

> 

>  igt_simple_main

> --

> 1.9.1

> 

> _______________________________________________

> Intel-gfx mailing list

> Intel-gfx@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Taylor, Clinton A Aug. 9, 2017, 12:15 a.m. UTC | #3 
On 08/08/2017 12:51 AM, Lofstedt, Marta wrote:
> Thanks Clinton!
>
> If you add:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100047
>
> You have my Rb.
> /Marta

Thanks Marta,
     However I'm going to extend the functionality to read the EDID 
block size like Daniel suggested. During testing today of the new edid 
size read SKL passed and IVB failed. This may be a result of an actual 
HDMI port vs LSPCON. More testing is required before I have a actual 
working test.

-Clint
>
>> -----Original Message-----
>> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
>> Of clinton.a.taylor@intel.com
>> Sent: Friday, August 4, 2017 9:23 PM
>> To: intel-gfx@lists.freedesktop.org
>> Subject: [Intel-gfx] [PATCH i-g-t] tests/kms: increase max threshold time for
>> edid read
>>
>> From: Clint Taylor <clinton.a.taylor@intel.com>
>>
>> Current 50ms max threshold timing for an EDID read is very close to the
>> actual time for a 2 block HDMI EDID read of 48ms. Any delay like a clock
>> stretch by the EDID eeprom will cause this test to fail. A 4 block HDMI EDID
>> read takes approximately 88ms under nominal conditions, making the max
>> threshold 95ms will allow this test to pass regardless of monitor attached.
>>
>> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
>> ---
>>   tests/kms_sysfs_edid_timing.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
>> index 1201388..b45e080 100644
>> --- a/tests/kms_sysfs_edid_timing.c
>> +++ b/tests/kms_sysfs_edid_timing.c
>> @@ -27,14 +27,14 @@
>>   #include <sys/stat.h>
>>
>>   #define THRESHOLD_PER_CONNECTOR	10
>> -#define THRESHOLD_TOTAL		50
>> +#define THRESHOLD_TOTAL		95
>>   #define CHECK_TIMES		15
>>
>>   IGT_TEST_DESCRIPTION("This check the time we take to read the content of
>> all "
>>   		     "the possible connectors. Without the edid -
>> ENXIO patch "
>>
>> "(http://permalink.gmane.org/gmane.comp.video.dri.devel/62083),"
>> -		     "we sometimes take a *really* long time. "
>> -		     "So let's just check for some reasonable
>> timing here");
>> +		     "we sometimes take a *really* long time. So
>> let's just "
>> +		     "check an approximate HDMI 4 block edid
>> read timing here");
>>
>>
>>   igt_simple_main
>> --
>> 1.9.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Chris Wilson Aug. 9, 2017, 11:21 p.m. UTC | #4 
Quoting Daniel Vetter (2017-08-07 17:20:27)
> On Fri, Aug 04, 2017 at 11:23:18AM -0700, clinton.a.taylor@intel.com wrote:
> > From: Clint Taylor <clinton.a.taylor@intel.com>
> > 
> > Current 50ms max threshold timing for an EDID read is very close to the
> > actual time for a 2 block HDMI EDID read of 48ms. Any delay like a clock
> > stretch by the EDID eeprom will cause this test to fail. A 4 block HDMI
> > EDID read takes approximately 88ms under nominal conditions, making the max
> > threshold 95ms will allow this test to pass regardless of monitor attached.
> > 
> > Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> 
> Per internal mail, this needs to be runtime adjusted to fit the EDID we're
> reading. Maybe 30ms per edid block.

Those are scary numbers. So please also a kms_flip flip-vs-edid
with timestamp check. Given the number of random probes we do, we must
make sure that we can do those in parallel to driving the display
fluidly. Similarly, some crc testing against edid reading would be in
order to make sure that there are no display glitches during the
transfer.
-Chris
diff mbox

Patch

diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
index 1201388..b45e080 100644
--- a/tests/kms_sysfs_edid_timing.c
+++ b/tests/kms_sysfs_edid_timing.c
@@ -27,14 +27,14 @@ 
 #include <sys/stat.h>
 
 #define THRESHOLD_PER_CONNECTOR	10
-#define THRESHOLD_TOTAL		50
+#define THRESHOLD_TOTAL		95
 #define CHECK_TIMES		15
 
 IGT_TEST_DESCRIPTION("This check the time we take to read the content of all "
 		     "the possible connectors. Without the edid -ENXIO patch "
 		     "(http://permalink.gmane.org/gmane.comp.video.dri.devel/62083), "
-		     "we sometimes take a *really* long time. "
-		     "So let's just check for some reasonable timing here");
+		     "we sometimes take a *really* long time. So let's just "
+		     "check an approximate HDMI 4 block edid read timing here");
 
 
 igt_simple_main