| Message ID | 20170810155522.31099-4-berrange@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/10/2017 10:55 AM, Daniel P. Berrange wrote: > Always use QKeyCode in the InputKeyEvent struct, by converting key > numbers to QKeyCode at the time the event is created. > > Signed-off-by: Daniel P. Berrange <berrange@redhat.com> > --- > ui/input.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Reviewed-by: Eric Blake <eblake@redhat.com> > diff --git a/ui/input.c b/ui/input.c > index af05f06368..64e9103a61 100644 > --- a/ui/input.c > +++ b/ui/input.c > @@ -400,10 +400,8 @@ void qemu_input_event_send_key(QemuConsole *src, KeyValue *key, bool down) > > void qemu_input_event_send_key_number(QemuConsole *src, int num, bool down) > { > - KeyValue *key = g_new0(KeyValue, 1); > - key->type = KEY_VALUE_KIND_NUMBER; > - key->u.number.data = num; > - qemu_input_event_send_key(src, key, down); > + QKeyCode code = qemu_input_key_number_to_qcode(num); > + qemu_input_event_send_key_qcode(src, code, down); > } > > void qemu_input_event_send_key_qcode(QemuConsole *src, QKeyCode q, bool down) >
diff --git a/ui/input.c b/ui/input.c index af05f06368..64e9103a61 100644 --- a/ui/input.c +++ b/ui/input.c @@ -400,10 +400,8 @@ void qemu_input_event_send_key(QemuConsole *src, KeyValue *key, bool down) void qemu_input_event_send_key_number(QemuConsole *src, int num, bool down) { - KeyValue *key = g_new0(KeyValue, 1); - key->type = KEY_VALUE_KIND_NUMBER; - key->u.number.data = num; - qemu_input_event_send_key(src, key, down); + QKeyCode code = qemu_input_key_number_to_qcode(num); + qemu_input_event_send_key_qcode(src, code, down); } void qemu_input_event_send_key_qcode(QemuConsole *src, QKeyCode q, bool down)
Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- ui/input.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)