| Message ID | 1502709581-26546-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Mon, Aug 14, 2017 at 1:19 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI > is identical to the R-Car Gen2 family. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > This patch is compiled and tested against mmc/next. > > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c > index 718cb8a..f709f7f 100644 > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c > @@ -95,6 +95,8 @@ > { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, }, > { .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, }, > { .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, }, > + { .compatible = "renesas,sdhi-r8a7743", .data = &of_rcar_gen2_compatible, }, > + { .compatible = "renesas,sdhi-r8a7745", .data = &of_rcar_gen2_compatible, }, > { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, }, > { .compatible = "renesas,sdhi-r8a7791", .data = &of_rcar_gen2_compatible, }, > { .compatible = "renesas,sdhi-r8a7792", .data = &of_rcar_gen2_compatible, }, I guess we want generic R-Car Gen2/3 compatible values here, too? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] > On Behalf Of Geert Uytterhoeven > Sent: 14 August 2017 15:22 > > On Mon, Aug 14, 2017 at 1:19 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is > > identical to the R-Car Gen2 family. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > --- > > This patch is compiled and tested against mmc/next. > > > > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c > > b/drivers/mmc/host/renesas_sdhi_sys_dmac.c > > index 718cb8a..f709f7f 100644 > > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c > > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c > > @@ -95,6 +95,8 @@ > > { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, }, > > { .compatible = "renesas,sdhi-r8a7778", .data = > &of_rcar_gen1_compatible, }, > > { .compatible = "renesas,sdhi-r8a7779", .data = > > &of_rcar_gen1_compatible, }, > > + { .compatible = "renesas,sdhi-r8a7743", .data = > &of_rcar_gen2_compatible, }, > > + { .compatible = "renesas,sdhi-r8a7745", .data = > > + &of_rcar_gen2_compatible, }, > > { .compatible = "renesas,sdhi-r8a7790", .data = > &of_rcar_gen2_compatible, }, > > { .compatible = "renesas,sdhi-r8a7791", .data = > &of_rcar_gen2_compatible, }, > > { .compatible = "renesas,sdhi-r8a7792", .data = > > &of_rcar_gen2_compatible, }, > > I guess we want generic R-Car Gen2/3 compatible values here, too? Yes, but I assume that should be a separate patch submitted instead of this one? Kind regards, Chris > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Chris, On Mon, Aug 14, 2017 at 5:15 PM, Chris Paterson <Chris.Paterson2@renesas.com> wrote: >> From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] >> On Behalf Of Geert Uytterhoeven >> Sent: 14 August 2017 15:22 >> >> On Mon, Aug 14, 2017 at 1:19 PM, Biju Das <biju.das@bp.renesas.com> wrote: >> > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is >> > identical to the R-Car Gen2 family. >> > >> > Signed-off-by: Biju Das <biju.das@bp.renesas.com> >> > --- >> > This patch is compiled and tested against mmc/next. >> > >> > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c >> > b/drivers/mmc/host/renesas_sdhi_sys_dmac.c >> > index 718cb8a..f709f7f 100644 >> > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c >> > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c >> > @@ -95,6 +95,8 @@ >> > { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, }, >> > { .compatible = "renesas,sdhi-r8a7778", .data = >> &of_rcar_gen1_compatible, }, >> > { .compatible = "renesas,sdhi-r8a7779", .data = >> > &of_rcar_gen1_compatible, }, >> > + { .compatible = "renesas,sdhi-r8a7743", .data = >> &of_rcar_gen2_compatible, }, >> > + { .compatible = "renesas,sdhi-r8a7745", .data = >> > + &of_rcar_gen2_compatible, }, >> > { .compatible = "renesas,sdhi-r8a7790", .data = >> &of_rcar_gen2_compatible, }, >> > { .compatible = "renesas,sdhi-r8a7791", .data = >> &of_rcar_gen2_compatible, }, >> > { .compatible = "renesas,sdhi-r8a7792", .data = >> > &of_rcar_gen2_compatible, }, >> >> I guess we want generic R-Car Gen2/3 compatible values here, too? > > Yes, but I assume that should be a separate patch submitted instead of this one? Indeed. That would avoid having to add the SoC-specific compatible values to the driver for all RZ/G1 variants. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello Geert, > From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] > On Behalf Of Geert Uytterhoeven > > Hi Chris, > > On Mon, Aug 14, 2017 at 5:15 PM, Chris Paterson > <Chris.Paterson2@renesas.com> wrote: > >> From: geert.uytterhoeven@gmail.com > >> [mailto:geert.uytterhoeven@gmail.com] > >> On Behalf Of Geert Uytterhoeven > >> Sent: 14 August 2017 15:22 > >> > >> On Mon, Aug 14, 2017 at 1:19 PM, Biju Das <biju.das@bp.renesas.com> > wrote: > >> > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is > >> > identical to the R-Car Gen2 family. > >> > > >> > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >> > --- > >> > This patch is compiled and tested against mmc/next. > >> > > >> > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++ > >> > 1 file changed, 2 insertions(+) > >> > > >> > diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c > >> > b/drivers/mmc/host/renesas_sdhi_sys_dmac.c > >> > index 718cb8a..f709f7f 100644 > >> > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c > >> > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c > >> > @@ -95,6 +95,8 @@ > >> > { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, > }, > >> > { .compatible = "renesas,sdhi-r8a7778", .data = > >> &of_rcar_gen1_compatible, }, > >> > { .compatible = "renesas,sdhi-r8a7779", .data = > >> > &of_rcar_gen1_compatible, }, > >> > + { .compatible = "renesas,sdhi-r8a7743", .data = > >> &of_rcar_gen2_compatible, }, > >> > + { .compatible = "renesas,sdhi-r8a7745", .data = > >> > + &of_rcar_gen2_compatible, }, > >> > { .compatible = "renesas,sdhi-r8a7790", .data = > >> &of_rcar_gen2_compatible, }, > >> > { .compatible = "renesas,sdhi-r8a7791", .data = > >> &of_rcar_gen2_compatible, }, > >> > { .compatible = "renesas,sdhi-r8a7792", .data = > >> > &of_rcar_gen2_compatible, }, > >> > >> I guess we want generic R-Car Gen2/3 compatible values here, too? > > > > Yes, but I assume that should be a separate patch submitted instead of this > one? > > Indeed. That would avoid having to add the SoC-specific compatible values to > the driver for all RZ/G1 variants. Okay. I'll send a new patch. Kind regards, Chris > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c index 718cb8a..f709f7f 100644 --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c @@ -95,6 +95,8 @@ { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, }, { .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, }, { .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, }, + { .compatible = "renesas,sdhi-r8a7743", .data = &of_rcar_gen2_compatible, }, + { .compatible = "renesas,sdhi-r8a7745", .data = &of_rcar_gen2_compatible, }, { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, }, { .compatible = "renesas,sdhi-r8a7791", .data = &of_rcar_gen2_compatible, }, { .compatible = "renesas,sdhi-r8a7792", .data = &of_rcar_gen2_compatible, },
Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family. Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- This patch is compiled and tested against mmc/next. drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++ 1 file changed, 2 insertions(+)