[3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures
diff mbox

Message ID 1502784594-14670-3-git-send-email-Julia.Lawall@lip6.fr
State New
Headers show

Commit Message

Julia Lawall Aug. 15, 2017, 8:09 a.m. UTC
These snd_rawmidi_ops structures are only passed as the third
argument of snd_rawmidi_set_ops.  This argument is const, so the
snd_rawmidi_ops structures can be const too.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 sound/firewire/motu/motu-midi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Takashi Sakamoto Aug. 15, 2017, 8:50 a.m. UTC | #1
Hi,

On Aug 15 2017 17:09, Julia Lawall wrote:
> These snd_rawmidi_ops structures are only passed as the third
> argument of snd_rawmidi_set_ops.  This argument is const, so the
> snd_rawmidi_ops structures can be const too.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>   sound/firewire/motu/motu-midi.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/firewire/motu/motu-midi.c b/sound/firewire/motu/motu-midi.c
> index e3acfcc..e55cab6 100644
> --- a/sound/firewire/motu/motu-midi.c
> +++ b/sound/firewire/motu/motu-midi.c
> @@ -128,12 +128,12 @@ static void set_midi_substream_names(struct snd_motu *motu,
>   
>   int snd_motu_create_midi_devices(struct snd_motu *motu)
>   {
> -	static struct snd_rawmidi_ops capture_ops = {
> +	static const struct snd_rawmidi_ops capture_ops = {
>   		.open		= midi_capture_open,
>   		.close		= midi_capture_close,
>   		.trigger	= midi_capture_trigger,
>   	};
> -	static struct snd_rawmidi_ops playback_ops = {
> +	static const struct snd_rawmidi_ops playback_ops = {
>   		.open		= midi_playback_open,
>   		.close		= midi_playback_close,
>   		.trigger	= midi_playback_trigger,

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>


Thanks

Takashi Sakamoto
Takashi Iwai Aug. 15, 2017, 8:55 a.m. UTC | #2
On Tue, 15 Aug 2017 10:09:54 +0200,
Julia Lawall wrote:
> 
> These snd_rawmidi_ops structures are only passed as the third
> argument of snd_rawmidi_set_ops.  This argument is const, so the
> snd_rawmidi_ops structures can be const too.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

What are other two patches?  Since I haven't received a cover letter,
no idea whether I overlooked them or not relevant with my tree...


thanks,

Takashi
Julia Lawall Aug. 15, 2017, 9 a.m. UTC | #3
On Tue, 15 Aug 2017, Takashi Iwai wrote:

> On Tue, 15 Aug 2017 10:09:54 +0200,
> Julia Lawall wrote:
> >
> > These snd_rawmidi_ops structures are only passed as the third
> > argument of snd_rawmidi_set_ops.  This argument is const, so the
> > snd_rawmidi_ops structures can be const too.
> >
> > Done with the help of Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> What are other two patches?  Since I haven't received a cover letter,
> no idea whether I overlooked them or not relevant with my tree...

Oops, I forgot to make a cover letter for this.  The others are:

drivers/hid/hid-prodikeys.c
drivers/usb/gadget/function/f_midi.c

julia
Takashi Iwai Aug. 15, 2017, 9:29 a.m. UTC | #4
On Tue, 15 Aug 2017 11:00:17 +0200,
Julia Lawall wrote:
> 
> 
> 
> On Tue, 15 Aug 2017, Takashi Iwai wrote:
> 
> > On Tue, 15 Aug 2017 10:09:54 +0200,
> > Julia Lawall wrote:
> > >
> > > These snd_rawmidi_ops structures are only passed as the third
> > > argument of snd_rawmidi_set_ops.  This argument is const, so the
> > > snd_rawmidi_ops structures can be const too.
> > >
> > > Done with the help of Coccinelle.
> > >
> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > What are other two patches?  Since I haven't received a cover letter,
> > no idea whether I overlooked them or not relevant with my tree...
> 
> Oops, I forgot to make a cover letter for this.  The others are:
> 
> drivers/hid/hid-prodikeys.c
> drivers/usb/gadget/function/f_midi.c

OK, thanks!


Takashi
Takashi Iwai Aug. 15, 2017, 12:06 p.m. UTC | #5
On Tue, 15 Aug 2017 10:09:54 +0200,
Julia Lawall wrote:
> 
> These snd_rawmidi_ops structures are only passed as the third
> argument of snd_rawmidi_set_ops.  This argument is const, so the
> snd_rawmidi_ops structures can be const too.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, applied now.


Takashi

Patch
diff mbox

diff --git a/sound/firewire/motu/motu-midi.c b/sound/firewire/motu/motu-midi.c
index e3acfcc..e55cab6 100644
--- a/sound/firewire/motu/motu-midi.c
+++ b/sound/firewire/motu/motu-midi.c
@@ -128,12 +128,12 @@  static void set_midi_substream_names(struct snd_motu *motu,
 
 int snd_motu_create_midi_devices(struct snd_motu *motu)
 {
-	static struct snd_rawmidi_ops capture_ops = {
+	static const struct snd_rawmidi_ops capture_ops = {
 		.open		= midi_capture_open,
 		.close		= midi_capture_close,
 		.trigger	= midi_capture_trigger,
 	};
-	static struct snd_rawmidi_ops playback_ops = {
+	static const struct snd_rawmidi_ops playback_ops = {
 		.open		= midi_playback_open,
 		.close		= midi_playback_close,
 		.trigger	= midi_playback_trigger,