diff mbox

[17/27] quota: Drop return value of mark_all_dquot_dirty()

Message ID 20170816154127.7048-18-jack@suse.cz (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Kara Aug. 16, 2017, 3:41 p.m. UTC 
Nobody uses the return value and later it would just complicate things.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/quota/dquot.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)
diff mbox

Patch

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index e1a155e8db15..234535ed8124 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -355,19 +355,13 @@  int dquot_mark_dquot_dirty(struct dquot *dquot)
 EXPORT_SYMBOL(dquot_mark_dquot_dirty);
 
 /* Dirtify all the dquots - this can block when journalling */
-static inline int mark_all_dquot_dirty(struct dquot * const *dquot)
+static void mark_all_dquot_dirty(struct dquot * const *dquot)
 {
-	int ret, err, cnt;
+	int cnt;
 
-	ret = err = 0;
-	for (cnt = 0; cnt < MAXQUOTAS; cnt++) {
+	for (cnt = 0; cnt < MAXQUOTAS; cnt++)
 		if (dquot[cnt])
-			/* Even in case of error we have to continue */
-			ret = mark_dquot_dirty(dquot[cnt]);
-		if (!err)
-			err = ret;
-	}
-	return err;
+			mark_dquot_dirty(dquot[cnt]);
 }
 
 static inline void dqput_all(struct dquot **dquot)