diff mbox

[v2,4/5] rockchip: rk322x: pinctrl: fix IO MASK error on sdcard pin

Message ID 1502954257-7256-5-git-send-email-kever.yang@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kever Yang Aug. 17, 2017, 7:17 a.m. UTC
Fix the IOMUX setting for SDcard CMD pin at the same time.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

Changes in v2: None

 drivers/pinctrl/rockchip/pinctrl_rk322x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philipp Tomsich Aug. 18, 2017, 1:01 p.m. UTC | #1
> Fix the IOMUX setting for SDcard CMD pin at the same time.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
> Changes in v2: None
> 
>  drivers/pinctrl/rockchip/pinctrl_rk322x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich Aug. 18, 2017, 4:04 p.m. UTC | #2
> Fix the IOMUX setting for SDcard CMD pin at the same time.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2: None
> 
>  drivers/pinctrl/rockchip/pinctrl_rk322x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich Aug. 18, 2017, 5:06 p.m. UTC | #3
> Fix the IOMUX setting for SDcard CMD pin at the same time.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2: None
> 
>  drivers/pinctrl/rockchip/pinctrl_rk322x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to u-boot-rockchip, thanks!
diff mbox

Patch

diff --git a/drivers/pinctrl/rockchip/pinctrl_rk322x.c b/drivers/pinctrl/rockchip/pinctrl_rk322x.c
index d9f8614..576b037 100644
--- a/drivers/pinctrl/rockchip/pinctrl_rk322x.c
+++ b/drivers/pinctrl/rockchip/pinctrl_rk322x.c
@@ -168,7 +168,7 @@  static void pinctrl_rk322x_sdmmc_config(struct rk322x_grf *grf, int mmc_id)
 		rk_clrsetreg(&grf->gpio1b_iomux,
 			     GPIO1B6_MASK | GPIO1B7_MASK,
 			     GPIO1B6_SDMMC_PWREN << GPIO1B6_SHIFT |
-			     GPIO1B7_SDMMC_CMD << GPIO1B6_SHIFT);
+			     GPIO1B7_SDMMC_CMD << GPIO1B7_SHIFT);
 		rk_clrsetreg(&grf->gpio1c_iomux, 0xfff,
 			     GPIO1C5_SDMMC_D3 << GPIO1C5_SHIFT |
 			     GPIO1C4_SDMMC_D2 << GPIO1C4_SHIFT |