| Message ID | 20170818123703.14870-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 18/08/17 15:37, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Slots can never be zero, PCI_SLOTS_INFO_SLOTS returns a value in the > range 0..7; slots is one more than this, 1..8 so cannot be zero and > so the zero check is redundant and can be removed. > > Detected by CoverityScan, CID#744269 ("Logically Dead Code") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/mmc/host/sdhci-pci-core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c > index 2c853cfa8389..43b2b09131bd 100644 > --- a/drivers/mmc/host/sdhci-pci-core.c > +++ b/drivers/mmc/host/sdhci-pci-core.c > @@ -1669,8 +1669,6 @@ static int sdhci_pci_probe(struct pci_dev *pdev, > > slots = PCI_SLOT_INFO_SLOTS(slots) + 1; > dev_dbg(&pdev->dev, "found %d slot(s)\n", slots); > - if (slots == 0) > - return -ENODEV; > > BUG_ON(slots > MAX_SLOTS); Isn't MAX_SLOTS == 8? So that is dead too. > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c index 2c853cfa8389..43b2b09131bd 100644 --- a/drivers/mmc/host/sdhci-pci-core.c +++ b/drivers/mmc/host/sdhci-pci-core.c @@ -1669,8 +1669,6 @@ static int sdhci_pci_probe(struct pci_dev *pdev, slots = PCI_SLOT_INFO_SLOTS(slots) + 1; dev_dbg(&pdev->dev, "found %d slot(s)\n", slots); - if (slots == 0) - return -ENODEV; BUG_ON(slots > MAX_SLOTS);