input/keyboard: fix platform_no_drv_owner.cocci warnings
diff mbox

Message ID alpine.DEB.2.20.1708201118140.3678@hadrien
State New
Headers show

Commit Message

Julia Lawall Aug. 20, 2017, 9:19 a.m. UTC
No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 dc_ti_pwrbtn.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Dmitry Torokhov Aug. 20, 2017, 4:28 p.m. UTC | #1
On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> No need to set .owner here. The core will do it.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  dc_ti_pwrbtn.c |    1 -

Hm, this driver is neither in my tree nor in next; where is it coming
from?

>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
>  static struct platform_driver dc_ti_pwrbtn_driver = {
>  	.driver = {
>  		.name = DRIVER_NAME,
> -		.owner = THIS_MODULE,
>  	},
>  	.probe	= dc_ti_pwrbtn_probe,
>  };
Julia Lawall Aug. 20, 2017, 4:44 p.m. UTC | #2
On Sun, 20 Aug 2017, Dmitry Torokhov wrote:

> On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> > No need to set .owner here. The core will do it.
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> >  dc_ti_pwrbtn.c |    1 -
>
> Hm, this driver is neither in my tree nor in next; where is it coming
> from?

Sorry, it's a kbuild message and I seem to have deleted the message with
that information...

julia

>
> >  1 file changed, 1 deletion(-)
> >
> > --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> > +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> > @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
> >  static struct platform_driver dc_ti_pwrbtn_driver = {
> >  	.driver = {
> >  		.name = DRIVER_NAME,
> > -		.owner = THIS_MODULE,
> >  	},
> >  	.probe	= dc_ti_pwrbtn_probe,
> >  };
>
> --
> Dmitry
>
Takashi Iwai Aug. 20, 2017, 8:35 p.m. UTC | #3
On Sun, 20 Aug 2017 18:28:41 +0200,
Dmitry Torokhov wrote:
> 
> On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> > No need to set .owner here. The core will do it.
> > 
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > 
> > Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> > 
> >  dc_ti_pwrbtn.c |    1 -
> 
> Hm, this driver is neither in my tree nor in next; where is it coming
> from?

It's only in my tree for testing, but kbuild bot takes all branches
unconditionally, so...

In anyway, I hope I can submit sooner or later :)


Takashi


> 
> >  1 file changed, 1 deletion(-)
> > 
> > --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> > +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> > @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
> >  static struct platform_driver dc_ti_pwrbtn_driver = {
> >  	.driver = {
> >  		.name = DRIVER_NAME,
> > -		.owner = THIS_MODULE,
> >  	},
> >  	.probe	= dc_ti_pwrbtn_probe,
> >  };
> 
> -- 
> Dmitry
>

Patch
diff mbox

--- a/drivers/input/keyboard/dc_ti_pwrbtn.c
+++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
@@ -75,7 +75,6 @@  static int dc_ti_pwrbtn_probe(struct pla
 static struct platform_driver dc_ti_pwrbtn_driver = {
 	.driver = {
 		.name = DRIVER_NAME,
-		.owner = THIS_MODULE,
 	},
 	.probe	= dc_ti_pwrbtn_probe,
 };