Patchwork [v9,2/2] dt-bindings: new binding for ps/2 gpio devices

login
register
mail settings
Submitter Danilo Krummrich
Date Aug. 21, 2017, 7:31 p.m.
Message ID <20170821193142.29688-3-danilokrummrich@dk-develop.de>
Download mbox | patch
Permalink /patch/9913575/
State Under Review
Headers show

Comments

Danilo Krummrich - Aug. 21, 2017, 7:31 p.m.
The PS/2 gpio device binding defines the gpio pins (data and clock)
as well as the interrupt which should be used to drive the ps/2 bus.
It is expected to get an interrupt on the falling edge of the clock
line.

Also it can be configured whether the host should support writing to
the device.

Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
---
 .../devicetree/bindings/serio/ps2-gpio.txt         | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/serio/ps2-gpio.txt
Rob Herring - Aug. 25, 2017, 6:03 p.m.
On Mon, Aug 21, 2017 at 09:31:42PM +0200, Danilo Krummrich wrote:
> The PS/2 gpio device binding defines the gpio pins (data and clock)
> as well as the interrupt which should be used to drive the ps/2 bus.
> It is expected to get an interrupt on the falling edge of the clock
> line.
> 
> Also it can be configured whether the host should support writing to
> the device.
> 
> Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
> ---
>  .../devicetree/bindings/serio/ps2-gpio.txt         | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/serio/ps2-gpio.txt

Acked-by: Rob Herring <robh@kernel.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dmitry Torokhov - Aug. 28, 2017, 5:02 p.m.
On Fri, Aug 25, 2017 at 01:03:23PM -0500, Rob Herring wrote:
> On Mon, Aug 21, 2017 at 09:31:42PM +0200, Danilo Krummrich wrote:
> > The PS/2 gpio device binding defines the gpio pins (data and clock)
> > as well as the interrupt which should be used to drive the ps/2 bus.
> > It is expected to get an interrupt on the falling edge of the clock
> > line.
> > 
> > Also it can be configured whether the host should support writing to
> > the device.
> > 
> > Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
> > ---
> >  .../devicetree/bindings/serio/ps2-gpio.txt         | 23 ++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/serio/ps2-gpio.txt
> 
> Acked-by: Rob Herring <robh@kernel.org>

Applied, thank you.

>

Patch

diff --git a/Documentation/devicetree/bindings/serio/ps2-gpio.txt b/Documentation/devicetree/bindings/serio/ps2-gpio.txt
new file mode 100644
index 000000000000..7b7bc9cdf986
--- /dev/null
+++ b/Documentation/devicetree/bindings/serio/ps2-gpio.txt
@@ -0,0 +1,23 @@ 
+Device-Tree binding for ps/2 gpio device
+
+Required properties:
+	- compatible = "ps2-gpio"
+	- data-gpios: the data pin
+	- clk-gpios: the clock pin
+	- interrupts: Should trigger on the falling edge of the clock line.
+
+Optional properties:
+	- write-enable: Indicates whether write function is provided
+	to serio device. Possibly providing the write fn will not work, because
+	of the tough timing requirements.
+
+Example nodes:
+
+ps2@0 {
+	compatible = "ps2-gpio";
+	interrupt-parent = <&gpio>;
+	interrupts = <23 IRQ_TYPE_EDGE_FALLING>;
+	data-gpios = <&gpio 24 GPIO_ACTIVE_HIGH>;
+	clk-gpios = <&gpio 23 GPIO_ACTIVE_HIGH>;
+	write-enable;
+};