Btrfs: do not reset bio->bi_ops while writing bio
diff mbox

Message ID 20170823181509.19816-1-bo.li.liu@oracle.com
State New
Headers show

Commit Message

Liu Bo Aug. 23, 2017, 6:15 p.m. UTC
flush_epd_write_bio() sets bio->bi_ops by itself to honor REQ_SYNC,
but it's not needed at all since bio->bi_ops has set up properly in
both __extent_writepage() and write_one_eb(), and in the case of
write_one_eb(), it also sets REQ_META, which we will lose in
flush_epd_write_bio().

This remove this unnecessary bio->bi_ops setting.

Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
 fs/btrfs/extent_io.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Christoph Hellwig Aug. 24, 2017, 2:10 p.m. UTC | #1
On Wed, Aug 23, 2017 at 12:15:09PM -0600, Liu Bo wrote:
> flush_epd_write_bio() sets bio->bi_ops by itself to honor REQ_SYNC,
> but it's not needed at all since bio->bi_ops has set up properly in
> both __extent_writepage() and write_one_eb(), and in the case of
> write_one_eb(), it also sets REQ_META, which we will lose in
> flush_epd_write_bio().
> 
> This remove this unnecessary bio->bi_ops setting.

Nitpick: it's bi_op, not bi_ops.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Liu Bo Aug. 24, 2017, 6:04 p.m. UTC | #2
On Thu, Aug 24, 2017 at 07:10:41AM -0700, Christoph Hellwig wrote:
> On Wed, Aug 23, 2017 at 12:15:09PM -0600, Liu Bo wrote:
> > flush_epd_write_bio() sets bio->bi_ops by itself to honor REQ_SYNC,
> > but it's not needed at all since bio->bi_ops has set up properly in
> > both __extent_writepage() and write_one_eb(), and in the case of
> > write_one_eb(), it also sets REQ_META, which we will lose in
> > flush_epd_write_bio().
> > 
> > This remove this unnecessary bio->bi_ops setting.
> 
> Nitpick: it's bi_op, not bi_ops.

Ah thanks, it's bio->bi_opf ;)

thanks,
-liubo
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christoph Hellwig Aug. 25, 2017, 7:46 a.m. UTC | #3
On Thu, Aug 24, 2017 at 11:04:40AM -0700, Liu Bo wrote:
> On Thu, Aug 24, 2017 at 07:10:41AM -0700, Christoph Hellwig wrote:
> > On Wed, Aug 23, 2017 at 12:15:09PM -0600, Liu Bo wrote:
> > > flush_epd_write_bio() sets bio->bi_ops by itself to honor REQ_SYNC,
> > > but it's not needed at all since bio->bi_ops has set up properly in
> > > both __extent_writepage() and write_one_eb(), and in the case of
> > > write_one_eb(), it also sets REQ_META, which we will lose in
> > > flush_epd_write_bio().
> > > 
> > > This remove this unnecessary bio->bi_ops setting.
> > 
> > Nitpick: it's bi_op, not bi_ops.
> 
> Ah thanks, it's bio->bi_opf ;)

Heh.  Of course..
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Sterba Sept. 6, 2017, 2:42 p.m. UTC | #4
On Wed, Aug 23, 2017 at 12:15:09PM -0600, Liu Bo wrote:
> flush_epd_write_bio() sets bio->bi_ops by itself to honor REQ_SYNC,
> but it's not needed at all since bio->bi_ops has set up properly in
> both __extent_writepage() and write_one_eb(), and in the case of
> write_one_eb(), it also sets REQ_META, which we will lose in
> flush_epd_write_bio().
> 
> This remove this unnecessary bio->bi_ops setting.
> 
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>

Reviewed-by: David Sterba <dsterba@suse.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index b61d68f..a454a10 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -4054,9 +4054,6 @@  static void flush_epd_write_bio(struct extent_page_data *epd)
 	if (epd->bio) {
 		int ret;
 
-		bio_set_op_attrs(epd->bio, REQ_OP_WRITE,
-				 epd->sync_io ? REQ_SYNC : 0);
-
 		ret = submit_one_bio(epd->bio, 0, 0);
 		BUG_ON(ret < 0); /* -ENOMEM */
 		epd->bio = NULL;