fs/xfs/kmem.c: fix coding style, using 'unsigned int' instead of 'unsigned'
diff mbox

Message ID 20170825052659.GA11087@fubar
State New
Headers show

Commit Message

Achilles Gaikwad Aug. 25, 2017, 5:26 a.m. UTC
Fixes a warning given by checkpatch.pl to use 'unsigned int'
instead of just 'unsigned'.

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+	unsigned nofs_flag = 0;

Signed-off-by: Achilles Gaikwad <achillesgaikwad@gmail.com>
---
 fs/xfs/kmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig Aug. 25, 2017, 7:45 a.m. UTC | #1
On Fri, Aug 25, 2017 at 10:56:59AM +0530, Achilles Gaikwad wrote:
> Fixes a warning given by checkpatch.pl to use 'unsigned int'
> instead of just 'unsigned'.
> 
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> +	unsigned nofs_flag = 0;

NAK.  This is churn for a totally pointless warnings - there is
not quantifiable benefit of 'unsigned int' which unigned has one
clear advantage: it's shorter.
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c
index 393b6849aeb3..a20909087e5e 100644
--- a/fs/xfs/kmem.c
+++ b/fs/xfs/kmem.c
@@ -48,7 +48,7 @@  kmem_alloc(size_t size, xfs_km_flags_t flags)
 void *
 kmem_zalloc_large(size_t size, xfs_km_flags_t flags)
 {
-	unsigned nofs_flag = 0;
+	unsigned int nofs_flag = 0;
 	void	*ptr;
 	gfp_t	lflags;