| Message ID | 1503963061-14763-5-git-send-email-ryans.lee@maximintegrated.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Aug 28, 2017 at 04:30:57PM -0700, Ryan Lee wrote: > Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com> Why are these variables obsolete? If their use was removed in earlier patches in the series they should be handled in that patch, if they're just unused say so. In general your changelogs could really benefit from being a bit longer and explaining why changes are being made. > mode change 100644 => 100755 sound/soc/codecs/max98927.h This also changes the permissions to be executable which isn't what we want.
>-----Original Message----- >From: Mark Brown [mailto:broonie@kernel.org] >Sent: Thursday, August 31, 2017 4:54 AM >To: Ryan Lee <RyanS.Lee@maximintegrated.com> >Cc: lgirdwood@gmail.com; perex@perex.cz; tiwai@suse.com; >kuninori.morimoto.gx@renesas.com; alsa-devel@alsa-project.org; linux- >kernel@vger.kernel.org; ryan.lee.maxim@gmail.com >Subject: Re: [PATCH 5/9] ASoC: max98927: Removed obsolete variables > >On Mon, Aug 28, 2017 at 04:30:57PM -0700, Ryan Lee wrote: >> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com> > >Why are these variables obsolete? If their use was removed in earlier patches in >the series they should be handled in that patch, if they're just unused say so. In >general your changelogs could really benefit from being a bit longer and >explaining why changes are being made. > >> mode change 100644 => 100755 sound/soc/codecs/max98927.h > >This also changes the permissions to be executable which isn't what we want. Thank you for your comment. I wanted to remove these variables because it have never been referred in max98927.c from the beginning.
diff --git a/sound/soc/codecs/max98927.h b/sound/soc/codecs/max98927.h old mode 100644 new mode 100755 index 3069a09..30cc40a --- a/sound/soc/codecs/max98927.h +++ b/sound/soc/codecs/max98927.h @@ -263,16 +263,12 @@ struct max98927_priv { struct regmap *regmap; struct snd_soc_codec *codec; - struct max98927_pdata *pdata; - unsigned int spk_gain; unsigned int sysclk; unsigned int v_l_slot; unsigned int i_l_slot; bool interleave_mode; unsigned int ch_size; - unsigned int rate; unsigned int iface; unsigned int master; - unsigned int digital_gain; }; #endif
Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com> --- sound/soc/codecs/max98927.h | 4 ---- 1 file changed, 4 deletions(-) mode change 100644 => 100755 sound/soc/codecs/max98927.h