diff mbox

[i-g-t] scripts/run-tests.sh: Use piglit's --ignore-missing

Message ID 20170901130903.26280-1-arkadiusz.hiler@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Arkadiusz Hiler Sept. 1, 2017, 1:09 p.m. UTC 
Recently we added a number of chamelium tests to the fast-feedback testlist.

Chemelium is build-optional - requires  `./configure --enable-chamelium`.

To mitigate issue with piglit exiting abruptly due to the (possibly)
missing test binaries, this makes it behave more gracefuly, considering
those as simply "notrun".

Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 scripts/run-tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Vetter Sept. 4, 2017, 8:33 a.m. UTC | #1 
On Fri, Sep 01, 2017 at 04:09:03PM +0300, Arkadiusz Hiler wrote:
> Recently we added a number of chamelium tests to the fast-feedback testlist.
> 
> Chemelium is build-optional - requires  `./configure --enable-chamelium`.
> 
> To mitigate issue with piglit exiting abruptly due to the (possibly)
> missing test binaries, this makes it behave more gracefuly, considering
> those as simply "notrun".
> 
> Cc: Petri Latvala <petri.latvala@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  scripts/run-tests.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
> index 7b8de74a..a28dd876 100755
> --- a/scripts/run-tests.sh
> +++ b/scripts/run-tests.sh
> @@ -129,7 +129,7 @@ if [ "x$RESUME" != "x" ]; then
>  	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" IGT_CONFIG_PATH="$IGT_CONFIG_PATH" "$PIGLIT" resume "$RESULTS" $NORETRY
>  else
>  	mkdir -p "$RESULTS"
> -	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" IGT_CONFIG_PATH="$IGT_CONFIG_PATH" "$PIGLIT" run igt -o "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
> +	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" IGT_CONFIG_PATH="$IGT_CONFIG_PATH" "$PIGLIT" run igt --ignore-missing -o "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
>  fi
>  
>  if [ "$SUMMARY" == "html" ]; then
> -- 
> 2.13.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Arkadiusz Hiler Sept. 4, 2017, 9:13 a.m. UTC | #2 
On Mon, Sep 04, 2017 at 10:33:32AM +0200, Daniel Vetter wrote:
> On Fri, Sep 01, 2017 at 04:09:03PM +0300, Arkadiusz Hiler wrote:
> > Recently we added a number of chamelium tests to the fast-feedback testlist.
> > 
> > Chemelium is build-optional - requires  `./configure --enable-chamelium`.
> > 
> > To mitigate issue with piglit exiting abruptly due to the (possibly)
> > missing test binaries, this makes it behave more gracefuly, considering
> > those as simply "notrun".
> > 
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

thanks for the review

pushed
diff mbox

Patch

diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
index 7b8de74a..a28dd876 100755
--- a/scripts/run-tests.sh
+++ b/scripts/run-tests.sh
@@ -129,7 +129,7 @@  if [ "x$RESUME" != "x" ]; then
 	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" IGT_CONFIG_PATH="$IGT_CONFIG_PATH" "$PIGLIT" resume "$RESULTS" $NORETRY
 else
 	mkdir -p "$RESULTS"
-	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" IGT_CONFIG_PATH="$IGT_CONFIG_PATH" "$PIGLIT" run igt -o "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
+	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" IGT_CONFIG_PATH="$IGT_CONFIG_PATH" "$PIGLIT" run igt --ignore-missing -o "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
 fi
 
 if [ "$SUMMARY" == "html" ]; then