Patchwork [v3] drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array.

login
register
mail settings
Submitter Allen
Date Sept. 13, 2017, 10:59 a.m.
Message ID <1505300371-31740-1-git-send-email-allen.lkml@gmail.com>
Download mbox | patch
Permalink /patch/9951041/
State New
Headers show

Comments

Allen - Sept. 13, 2017, 10:59 a.m.
Use ARRAY_SIZE() macro instead of TELEM_EVT_LEN().

v3: Replace TELEM_EVT_LEN() with ARRAY_SIZE().

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/platform/x86/intel_telemetry_debugfs.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)
Darren Hart - Sept. 22, 2017, 9:57 p.m.
On Wed, Sep 13, 2017 at 04:29:31PM +0530, Allen Pais wrote:
>  Use ARRAY_SIZE() macro instead of TELEM_EVT_LEN().
> 
> v3: Replace TELEM_EVT_LEN() with ARRAY_SIZE().
> 
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>

Thanks Allen, queued for testing with minor changelog changes.

> ---

Note: in the future, the changelog (Since v1:, Since v2: goes here, below the
--- line. Also, don't delete the previous changes. See:

Documentation/process/submitting-patches.rst

14) The canonical patch format

Patch

diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c
index d4fc42b..74e518d 100644
--- a/drivers/platform/x86/intel_telemetry_debugfs.c
+++ b/drivers/platform/x86/intel_telemetry_debugfs.c
@@ -76,8 +76,6 @@ 
 #define TELEM_IOSS_DX_D0IX_EVTS		25
 #define TELEM_IOSS_PG_EVTS		30
 
-#define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
-
 #define TELEM_DEBUGFS_CPU(model, data) \
 	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data}
 
@@ -304,13 +302,13 @@  static struct telemetry_debugfs_conf telem_apl_debugfs_conf = {
 	.ioss_d0ix_data = telem_apl_ioss_d0ix_data,
 	.ioss_pg_data = telem_apl_ioss_pg_data,
 
-	.pss_idle_evts = TELEM_EVT_LEN(telem_apl_pss_idle_data),
-	.pcs_idle_blkd_evts = TELEM_EVT_LEN(telem_apl_pcs_idle_blkd_data),
-	.pcs_s0ix_blkd_evts = TELEM_EVT_LEN(telem_apl_pcs_s0ix_blkd_data),
-	.pss_ltr_evts = TELEM_EVT_LEN(telem_apl_pss_ltr_data),
-	.pss_wakeup_evts = TELEM_EVT_LEN(telem_apl_pss_wakeup),
-	.ioss_d0ix_evts = TELEM_EVT_LEN(telem_apl_ioss_d0ix_data),
-	.ioss_pg_evts = TELEM_EVT_LEN(telem_apl_ioss_pg_data),
+	.pss_idle_evts = ARRAY_SIZE(telem_apl_pss_idle_data),
+	.pcs_idle_blkd_evts = ARRAY_SIZE(telem_apl_pcs_idle_blkd_data),
+	.pcs_s0ix_blkd_evts = ARRAY_SIZE(telem_apl_pcs_s0ix_blkd_data),
+	.pss_ltr_evts = ARRAY_SIZE(telem_apl_pss_ltr_data),
+	.pss_wakeup_evts = ARRAY_SIZE(telem_apl_pss_wakeup),
+	.ioss_d0ix_evts = ARRAY_SIZE(telem_apl_ioss_d0ix_data),
+	.ioss_pg_evts = ARRAY_SIZE(telem_apl_ioss_pg_data),
 
 	.pstates_id = TELEM_APL_PSS_PSTATES_ID,
 	.pss_idle_id = TELEM_APL_PSS_IDLE_ID,