diff mbox

[v2] gpu: ipu-v3: ipu-dc: Remove unused 'di' variable

Message ID 1505610202-23655-1-git-send-email-festevam@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam Sept. 17, 2017, 1:03 a.m. UTC 
From: Fabio Estevam <fabio.estevam@nxp.com>

The 'di' variable is never used inside ipu_dc_enable_channel(),
so just remove it.

This fixes the following build warning with W=1:

drivers/gpu/ipu-v3/ipu-dc.c: In function 'ipu_dc_enable_channel':
drivers/gpu/ipu-v3/ipu-dc.c:252:6: warning: variable 'di' set but not used [-Wunused-but-set-variable] 

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Changes since v1:
- Fix a typo in the function name in the commit log.

 drivers/gpu/ipu-v3/ipu-dc.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Philipp Zabel Oct. 4, 2017, 10:20 a.m. UTC | #1 
On Sat, 2017-09-16 at 22:03 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> The 'di' variable is never used inside ipu_dc_enable_channel(),
> so just remove it.
> 
> This fixes the following build warning with W=1:
> 
> drivers/gpu/ipu-v3/ipu-dc.c: In function 'ipu_dc_enable_channel':
> drivers/gpu/ipu-v3/ipu-dc.c:252:6: warning: variable 'di' set but not
> used [-Wunused-but-set-variable] 
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Thank you, applied to imx-drm/next.

regards
Philipp
diff mbox

Patch

diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c
index 7a4b836..49bfe6e 100644
--- a/drivers/gpu/ipu-v3/ipu-dc.c
+++ b/drivers/gpu/ipu-v3/ipu-dc.c
@@ -249,11 +249,8 @@  EXPORT_SYMBOL_GPL(ipu_dc_enable);
 
 void ipu_dc_enable_channel(struct ipu_dc *dc)
 {
-	int di;
 	u32 reg;
 
-	di = dc->di;
-
 	reg = readl(dc->base + DC_WR_CH_CONF);
 	reg |= DC_WR_CH_CONF_PROG_TYPE_NORMAL;
 	writel(reg, dc->base + DC_WR_CH_CONF);