NFS: Cleanup error handling in nfs_idmap_request_key()
diff mbox

Message ID 20170920215346.bgucxg77ayrcx6zy@mwanda
State New
Headers show

Commit Message

Dan Carpenter Sept. 20, 2017, 9:53 p.m. UTC
nfs_idmap_get_desc() can't actually return zero.  But if it did then
we would return ERR_PTR(0) which is NULL and the caller,
nfs_idmap_get_key(), doesn't expect that so it leads to a NULL pointer

I've cleaned this up by changing the "<=" to "<" so it's more clear that
we don't return ERR_PTR(0).

Signed-off-by: Dan Carpenter <>

To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to
More majordomo info at

diff mbox

diff --git a/fs/nfs/nfs4idmap.c b/fs/nfs/nfs4idmap.c
index dd5d27da8c0c..30426c1a1bbd 100644
--- a/fs/nfs/nfs4idmap.c
+++ b/fs/nfs/nfs4idmap.c
@@ -274,7 +274,7 @@  static struct key *nfs_idmap_request_key(const char *name, size_t namelen,
 	ssize_t ret;
 	ret = nfs_idmap_get_desc(name, namelen, type, strlen(type), &desc);
-	if (ret <= 0)
+	if (ret < 0)
 		return ERR_PTR(ret);
 	rkey = request_key(&key_type_id_resolver, desc, "");