From patchwork Wed Sep 20 22:59:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Anholt X-Patchwork-Id: 9962897 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E6E3A6056A for ; Wed, 20 Sep 2017 23:00:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D718529277 for ; Wed, 20 Sep 2017 23:00:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C509E29279; Wed, 20 Sep 2017 23:00:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 02C1929274 for ; Wed, 20 Sep 2017 23:00:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D5AA76E7EE; Wed, 20 Sep 2017 22:59:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 816E66E7F0 for ; Wed, 20 Sep 2017 22:59:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 36F1A10A01F2; Wed, 20 Sep 2017 15:59:39 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id N7ebA_ZMkxqD; Wed, 20 Sep 2017 15:59:37 -0700 (PDT) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id CD9DF10A0EED; Wed, 20 Sep 2017 15:59:36 -0700 (PDT) Received: by eliezer.anholt.net (Postfix, from userid 1000) id DE7E72FE21E1; Wed, 20 Sep 2017 15:59:35 -0700 (PDT) From: Eric Anholt To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/2] drm/vc4: Update kerneldoc about CEC and power management Date: Wed, 20 Sep 2017 15:59:35 -0700 Message-Id: <20170920225935.14566-2-eric@anholt.net> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170920225935.14566-1-eric@anholt.net> References: <20170920225935.14566-1-eric@anholt.net> Cc: Hans Verkuil , linux-kernel@vger.kernel.org, Boris Brezillon X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Boris had added full power management, and then Hans partially removed it to enable CEC, so update the docs about both. Cc: Boris Brezillon Cc: Hans Verkuil Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_hdmi.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 65826a4f208e..ce18384c6be3 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -33,13 +33,9 @@ * interconnect) bus to the encoder side for insertion into the video * blank regions. * - * The driver's HDMI encoder does not yet support power management. - * The HDMI encoder's power domain and the HSM/pixel clocks are kept - * continuously running, and only the HDMI logic and packet ram are - * powered off/on at disable/enable time. - * - * The driver does not yet support CEC control, though the HDMI - * encoder block has CEC support. + * Note that HDMI CEC requires that the HSM clock be running even when + * not scanning out, so that input can be processed. The PHY is still + * powered down when not scanning out, though. */ #include