[3/3] arm64: dts: mt2712: Add auxadc device node.
diff mbox

Message ID 1505957212-13402-4-git-send-email-zhiyong.tao@mediatek.com
State New
Headers show

Commit Message

Zhiyong Tao Sept. 21, 2017, 1:26 a.m. UTC
Add auxadc device node for MT2712.

Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
---
This patch dependents on "Mediatek MT2712 clock and scpsys support"[1].
Please accept this patch together with [1].
[1]http://lists.infradead.org/pipermail/linux-mediatek/2017-September/010461.html
---
 arch/arm64/boot/dts/mediatek/mt2712-evb.dts |    4 ++++
 arch/arm64/boot/dts/mediatek/mt2712e.dtsi   |    9 +++++++++
 2 files changed, 13 insertions(+)

Comments

Jonathan Cameron Sept. 24, 2017, 3:47 p.m. UTC | #1
On Thu, 21 Sep 2017 09:26:52 +0800
Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:

> Add auxadc device node for MT2712.
> 
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>

I've applied the IIO patches to make this work, so assume this will get
picked up in due course.

Jonathan

> ---
> This patch dependents on "Mediatek MT2712 clock and scpsys support"[1].
> Please accept this patch together with [1].
> [1]http://lists.infradead.org/pipermail/linux-mediatek/2017-September/010461.html
> ---
>  arch/arm64/boot/dts/mediatek/mt2712-evb.dts |    4 ++++
>  arch/arm64/boot/dts/mediatek/mt2712e.dtsi   |    9 +++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> index 14163b9..76cbf4a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> @@ -28,6 +28,10 @@
>  	};
>  };
>  
> +&auxadc {
> +	status = "okay";
> +};
> +
>  &uart0 {
>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> index 3232e4e..bf65c92 100644
> --- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> @@ -225,6 +225,15 @@
>  			 (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_HIGH)>;
>  	};
>  
> +	auxadc: adc@11001000 {
> +		compatible = "mediatek,mt2712-auxadc";
> +		reg = <0 0x11001000 0 0x1000>;
> +		clocks = <&pericfg CLK_PERI_AUXADC>;
> +		clock-names = "main";
> +		#io-channel-cells = <1>;
> +		status = "disabled";
> +	};
> +
>  	uart0: serial@11002000 {
>  		compatible = "mediatek,mt2712-uart",
>  			     "mediatek,mt6577-uart";
Matthias Brugger Oct. 13, 2017, 3:11 p.m. UTC | #2
On 09/24/2017 05:47 PM, Jonathan Cameron wrote:
> On Thu, 21 Sep 2017 09:26:52 +0800
> Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
> 
>> Add auxadc device node for MT2712.
>>
>> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> 
> I've applied the IIO patches to make this work, so assume this will get
> picked up in due course.
> 

pushed now to v4.14-next/dts64
Thanks.

> Jonathan
> 
>> ---
>> This patch dependents on "Mediatek MT2712 clock and scpsys support"[1].
>> Please accept this patch together with [1].
>> [1]http://lists.infradead.org/pipermail/linux-mediatek/2017-September/010461.html
>> ---
>>   arch/arm64/boot/dts/mediatek/mt2712-evb.dts |    4 ++++
>>   arch/arm64/boot/dts/mediatek/mt2712e.dtsi   |    9 +++++++++
>>   2 files changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> index 14163b9..76cbf4a 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> @@ -28,6 +28,10 @@
>>   	};
>>   };
>>   
>> +&auxadc {
>> +	status = "okay";
>> +};
>> +
>>   &uart0 {
>>   	status = "okay";
>>   };
>> diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
>> index 3232e4e..bf65c92 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
>> @@ -225,6 +225,15 @@
>>   			 (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_HIGH)>;
>>   	};
>>   
>> +	auxadc: adc@11001000 {
>> +		compatible = "mediatek,mt2712-auxadc";
>> +		reg = <0 0x11001000 0 0x1000>;
>> +		clocks = <&pericfg CLK_PERI_AUXADC>;
>> +		clock-names = "main";
>> +		#io-channel-cells = <1>;
>> +		status = "disabled";
>> +	};
>> +
>>   	uart0: serial@11002000 {
>>   		compatible = "mediatek,mt2712-uart",
>>   			     "mediatek,mt6577-uart";
>
Matthias Brugger Oct. 16, 2017, 3:09 p.m. UTC | #3
On 10/13/2017 05:11 PM, Matthias Brugger wrote:
> 
> 
> On 09/24/2017 05:47 PM, Jonathan Cameron wrote:
>> On Thu, 21 Sep 2017 09:26:52 +0800
>> Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
>>
>>> Add auxadc device node for MT2712.
>>>
>>> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
>>
>> I've applied the IIO patches to make this work, so assume this will get
>> picked up in due course.
>>
> 
> pushed now to v4.14-next/dts64
> Thanks.
> 

I realized that this needs the mt2712 clock patches to actually work.
Dropped for now. Please resubmit as soon as mt2712 clock patches got [1] 
accepted upstream.

Thanks,
Matthias

[1] https://lkml.org/lkml/2017/9/19/9
Matthias Brugger March 19, 2018, 1:51 a.m. UTC | #4
On 10/16/2017 05:09 PM, Matthias Brugger wrote:
> 
> 
> On 10/13/2017 05:11 PM, Matthias Brugger wrote:
>>
>>
>> On 09/24/2017 05:47 PM, Jonathan Cameron wrote:
>>> On Thu, 21 Sep 2017 09:26:52 +0800
>>> Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
>>>
>>>> Add auxadc device node for MT2712.
>>>>
>>>> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
>>>
>>> I've applied the IIO patches to make this work, so assume this will get
>>> picked up in due course.
>>>
>>
>> pushed now to v4.14-next/dts64
>> Thanks.
>>
> 
> I realized that this needs the mt2712 clock patches to actually work.
> Dropped for now. Please resubmit as soon as mt2712 clock patches got [1]
> accepted upstream.
> 

I think you actually never resubmitted. Anyway I pushed it now to v4.16-next/dts64

Thanks.

> Thanks,
> Matthias
> 
> [1] https://lkml.org/lkml/2017/9/19/9

Patch
diff mbox

diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
index 14163b9..76cbf4a 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
@@ -28,6 +28,10 @@ 
 	};
 };
 
+&auxadc {
+	status = "okay";
+};
+
 &uart0 {
 	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
index 3232e4e..bf65c92 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
@@ -225,6 +225,15 @@ 
 			 (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_HIGH)>;
 	};
 
+	auxadc: adc@11001000 {
+		compatible = "mediatek,mt2712-auxadc";
+		reg = <0 0x11001000 0 0x1000>;
+		clocks = <&pericfg CLK_PERI_AUXADC>;
+		clock-names = "main";
+		#io-channel-cells = <1>;
+		status = "disabled";
+	};
+
 	uart0: serial@11002000 {
 		compatible = "mediatek,mt2712-uart",
 			     "mediatek,mt6577-uart";