[09/14] ieee802154: ca8210: fix some kernel coding style errors
diff mbox

Message ID 20170922121405.31789-10-stefan@osg.samsung.com
State Accepted
Headers show

Commit Message

Stefan Schmidt Sept. 22, 2017, 12:14 p.m. UTC
Remove unneeded parentheses and fix format for pointer style.

Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
---
 drivers/net/ieee802154/ca8210.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Harry Morris Nov. 6, 2017, 3:27 p.m. UTC | #1
On 22/09/2017 13:14, Stefan Schmidt wrote:
> Remove unneeded parentheses and fix format for pointer style.
>
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
> ---
>   drivers/net/ieee802154/ca8210.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index 24a1eabbbc9d..66829055aa8b 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -1303,7 +1303,7 @@ static u8 tdme_checkpibattribute(
>   		break;
>   	/* MAC */
>   	case MAC_BATT_LIFE_EXT_PERIODS:
> -		if ((value < 6) || (value > 41))
> +		if (value < 6 || value > 41)
>   			status = MAC_INVALID_PARAMETER;
>   		break;
>   	case MAC_BEACON_PAYLOAD:
> @@ -1319,7 +1319,7 @@ static u8 tdme_checkpibattribute(
>   			status = MAC_INVALID_PARAMETER;
>   		break;
>   	case MAC_MAX_BE:
> -		if ((value < 3) || (value > 8))
> +		if (value < 3 || value > 8)
>   			status = MAC_INVALID_PARAMETER;
>   		break;
>   	case MAC_MAX_CSMA_BACKOFFS:
> @@ -1335,7 +1335,7 @@ static u8 tdme_checkpibattribute(
>   			status = MAC_INVALID_PARAMETER;
>   		break;
>   	case MAC_RESPONSE_WAIT_TIME:
> -		if ((value < 2) || (value > 64))
> +		if (value < 2 || value > 64)
>   			status = MAC_INVALID_PARAMETER;
>   		break;
>   	case MAC_SUPERFRAME_ORDER:
> @@ -1511,7 +1511,7 @@ static u8 mcps_data_request(
>   	psec = (struct secspec *)(command.pdata.data_req.msdu + msdu_length);
>   	command.length = sizeof(struct mcps_data_request_pset) -
>   		MAX_DATA_SIZE + msdu_length;
> -	if (!security || (security->security_level == 0)) {
> +	if (!security || security->security_level == 0) {
>   		psec->security_level = 0;
>   		command.length += 1;
>   	} else {
> @@ -1561,7 +1561,7 @@ static u8 mlme_reset_request_sync(
>   	status = response.pdata.status;
>   
>   	/* reset COORD Bit for Channel Filtering as Coordinator */
> -	if (CA8210_MAC_WORKAROUNDS && set_default_pib && (!status)) {
> +	if (CA8210_MAC_WORKAROUNDS && set_default_pib && !status) {
>   		status = tdme_setsfr_request_sync(
>   			0,
>   			CA8210_SFR_MACCON,
> @@ -2369,7 +2369,7 @@ static int ca8210_set_promiscuous_mode(struct ieee802154_hw *hw, const bool on)
>   		MAC_PROMISCUOUS_MODE,
>   		0,
>   		1,
> -		(const void*)&on,
> +		(const void *)&on,
>   		priv->spi
>   	);
>   	if (status) {

Acked-by: Harry Morris <h.morris@cascoda.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stefan Schmidt Nov. 6, 2017, 3:40 p.m. UTC | #2
Hello.

On 06.11.2017 16:27, Harry Morris wrote:
> On 22/09/2017 13:14, Stefan Schmidt wrote:
>> Remove unneeded parentheses and fix format for pointer style.
>>
>> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
>> ---
>>   drivers/net/ieee802154/ca8210.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/ieee802154/ca8210.c
>> b/drivers/net/ieee802154/ca8210.c
>> index 24a1eabbbc9d..66829055aa8b 100644
>> --- a/drivers/net/ieee802154/ca8210.c
>> +++ b/drivers/net/ieee802154/ca8210.c
>> @@ -1303,7 +1303,7 @@ static u8 tdme_checkpibattribute(
>>           break;
>>       /* MAC */
>>       case MAC_BATT_LIFE_EXT_PERIODS:
>> -        if ((value < 6) || (value > 41))
>> +        if (value < 6 || value > 41)
>>               status = MAC_INVALID_PARAMETER;
>>           break;
>>       case MAC_BEACON_PAYLOAD:
>> @@ -1319,7 +1319,7 @@ static u8 tdme_checkpibattribute(
>>               status = MAC_INVALID_PARAMETER;
>>           break;
>>       case MAC_MAX_BE:
>> -        if ((value < 3) || (value > 8))
>> +        if (value < 3 || value > 8)
>>               status = MAC_INVALID_PARAMETER;
>>           break;
>>       case MAC_MAX_CSMA_BACKOFFS:
>> @@ -1335,7 +1335,7 @@ static u8 tdme_checkpibattribute(
>>               status = MAC_INVALID_PARAMETER;
>>           break;
>>       case MAC_RESPONSE_WAIT_TIME:
>> -        if ((value < 2) || (value > 64))
>> +        if (value < 2 || value > 64)
>>               status = MAC_INVALID_PARAMETER;
>>           break;
>>       case MAC_SUPERFRAME_ORDER:
>> @@ -1511,7 +1511,7 @@ static u8 mcps_data_request(
>>       psec = (struct secspec *)(command.pdata.data_req.msdu +
>> msdu_length);
>>       command.length = sizeof(struct mcps_data_request_pset) -
>>           MAX_DATA_SIZE + msdu_length;
>> -    if (!security || (security->security_level == 0)) {
>> +    if (!security || security->security_level == 0) {
>>           psec->security_level = 0;
>>           command.length += 1;
>>       } else {
>> @@ -1561,7 +1561,7 @@ static u8 mlme_reset_request_sync(
>>       status = response.pdata.status;
>>         /* reset COORD Bit for Channel Filtering as Coordinator */
>> -    if (CA8210_MAC_WORKAROUNDS && set_default_pib && (!status)) {
>> +    if (CA8210_MAC_WORKAROUNDS && set_default_pib && !status) {
>>           status = tdme_setsfr_request_sync(
>>               0,
>>               CA8210_SFR_MACCON,
>> @@ -2369,7 +2369,7 @@ static int ca8210_set_promiscuous_mode(struct
>> ieee802154_hw *hw, const bool on)
>>           MAC_PROMISCUOUS_MODE,
>>           0,
>>           1,
>> -        (const void*)&on,
>> +        (const void *)&on,
>>           priv->spi
>>       );
>>       if (status) {
> 
> Acked-by: Harry Morris <h.morris@cascoda.com>

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 24a1eabbbc9d..66829055aa8b 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -1303,7 +1303,7 @@  static u8 tdme_checkpibattribute(
 		break;
 	/* MAC */
 	case MAC_BATT_LIFE_EXT_PERIODS:
-		if ((value < 6) || (value > 41))
+		if (value < 6 || value > 41)
 			status = MAC_INVALID_PARAMETER;
 		break;
 	case MAC_BEACON_PAYLOAD:
@@ -1319,7 +1319,7 @@  static u8 tdme_checkpibattribute(
 			status = MAC_INVALID_PARAMETER;
 		break;
 	case MAC_MAX_BE:
-		if ((value < 3) || (value > 8))
+		if (value < 3 || value > 8)
 			status = MAC_INVALID_PARAMETER;
 		break;
 	case MAC_MAX_CSMA_BACKOFFS:
@@ -1335,7 +1335,7 @@  static u8 tdme_checkpibattribute(
 			status = MAC_INVALID_PARAMETER;
 		break;
 	case MAC_RESPONSE_WAIT_TIME:
-		if ((value < 2) || (value > 64))
+		if (value < 2 || value > 64)
 			status = MAC_INVALID_PARAMETER;
 		break;
 	case MAC_SUPERFRAME_ORDER:
@@ -1511,7 +1511,7 @@  static u8 mcps_data_request(
 	psec = (struct secspec *)(command.pdata.data_req.msdu + msdu_length);
 	command.length = sizeof(struct mcps_data_request_pset) -
 		MAX_DATA_SIZE + msdu_length;
-	if (!security || (security->security_level == 0)) {
+	if (!security || security->security_level == 0) {
 		psec->security_level = 0;
 		command.length += 1;
 	} else {
@@ -1561,7 +1561,7 @@  static u8 mlme_reset_request_sync(
 	status = response.pdata.status;
 
 	/* reset COORD Bit for Channel Filtering as Coordinator */
-	if (CA8210_MAC_WORKAROUNDS && set_default_pib && (!status)) {
+	if (CA8210_MAC_WORKAROUNDS && set_default_pib && !status) {
 		status = tdme_setsfr_request_sync(
 			0,
 			CA8210_SFR_MACCON,
@@ -2369,7 +2369,7 @@  static int ca8210_set_promiscuous_mode(struct ieee802154_hw *hw, const bool on)
 		MAC_PROMISCUOUS_MODE,
 		0,
 		1,
-		(const void*)&on,
+		(const void *)&on,
 		priv->spi
 	);
 	if (status) {