| Message ID | 1506336008-4480-4-git-send-email-harinath922@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 25.09.2017 12:40 schrieb Harinath Nampally: > 'mma8452_read_thresh' and 'mma8452_write_thresh' functions > does more than just read/write threshold values. > They also handle IIO_EV_INFO_HIGH_PASS_FILTER_3DB and > IIO_EV_INFO_PERIOD therefore renaming to generic names. > > Improves code readability, no impact on functionality. > > Signed-off-by: Harinath Nampally <harinath922@gmail.com> Acked-by: Martin Kepplinger <martink@posteo.de> -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 27 Sep 2017 08:46:27 +0200 Martin Kepplinger <martink@posteo.de> wrote: > Am 25.09.2017 12:40 schrieb Harinath Nampally: > > 'mma8452_read_thresh' and 'mma8452_write_thresh' functions > > does more than just read/write threshold values. > > They also handle IIO_EV_INFO_HIGH_PASS_FILTER_3DB and > > IIO_EV_INFO_PERIOD therefore renaming to generic names. > > > > Improves code readability, no impact on functionality. > > > > Signed-off-by: Harinath Nampally <harinath922@gmail.com> > > Acked-by: Martin Kepplinger <martink@posteo.de> Just this patch 3 applied for now to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with. Thanks, Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 74b6221..43c3a6b 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -792,7 +792,7 @@ static int mma8452_get_event_regs(struct mma8452_data *data, } } -static int mma8452_read_thresh(struct iio_dev *indio_dev, +static int mma8452_read_event_value(struct iio_dev *indio_dev, const struct iio_chan_spec *chan, enum iio_event_type type, enum iio_event_direction dir, @@ -855,7 +855,7 @@ static int mma8452_read_thresh(struct iio_dev *indio_dev, } } -static int mma8452_write_thresh(struct iio_dev *indio_dev, +static int mma8452_write_event_value(struct iio_dev *indio_dev, const struct iio_chan_spec *chan, enum iio_event_type type, enum iio_event_direction dir, @@ -1391,8 +1391,8 @@ static const struct iio_info mma8452_info = { .read_raw = &mma8452_read_raw, .write_raw = &mma8452_write_raw, .event_attrs = &mma8452_event_attribute_group, - .read_event_value = &mma8452_read_thresh, - .write_event_value = &mma8452_write_thresh, + .read_event_value = &mma8452_read_event_value, + .write_event_value = &mma8452_write_event_value, .read_event_config = &mma8452_read_event_config, .write_event_config = &mma8452_write_event_config, .debugfs_reg_access = &mma8452_reg_access_dbg,
'mma8452_read_thresh' and 'mma8452_write_thresh' functions does more than just read/write threshold values. They also handle IIO_EV_INFO_HIGH_PASS_FILTER_3DB and IIO_EV_INFO_PERIOD therefore renaming to generic names. Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally <harinath922@gmail.com> --- drivers/iio/accel/mma8452.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)