[v2] ARM: support XZ compressed kernels
diff mbox

Message ID op.vy0nbsz22s3iss@ecaz
State New, archived
Headers show

Commit Message

Imre Kaloz July 22, 2011, 10:27 a.m. UTC
On Fri, 22 Jul 2011 11:57:38 +0200, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> On Fri, Jul 22, 2011 at 11:52:19AM +0200, Imre Kaloz wrote:
>
>> Guessed I'm not the one outside the ARM community, so.. I can say it
>> didn't break neither ppc or mips for me, but have no idea who's feedback
>> are you waiting for.
>
> What I'm concerned about is the apparant lack of exposure of the patch
> to people outside of ARM, especially as it touches lib/xz/xz_dec_stream.c.
>
> I have no idea whether that breaks some architecture or not.
>
> Is Lasse Collin (the original contributer of that file) aware of this
> change?
>
> What is the additional include fixing on ARM?  Why isn't this include
> needed on other architectures?  And why isn't any of this mentioned in
> the patch commit log?
>

It's needed because of missing min_t - but just looked a bit further and it seems decompress.c should use kernel.h - so I send v3 right away with the following change if you agree:

Patch
diff mbox

--- a/arch/arm/boot/compressed/decompress.c
+++ b/arch/arm/boot/compressed/decompress.c
@@ -1,7 +1,7 @@ 
  #define _LINUX_STRING_H_

  #include <linux/compiler.h>	/* for inline */
-#include <linux/types.h>	/* for size_t */
+#include <linux/kernel.h>	/* for min_t */
  #include <linux/stddef.h>	/* for NULL */
  #include <linux/linkage.h>
  #include <asm/string.h>