PM / ACPI: Removed unused function
diff mbox

Message ID 1507273714-26394-1-git-send-email-ulf.hansson@linaro.org
State Mainlined
Delegated to: Rafael Wysocki
Headers show

Commit Message

Ulf Hansson Oct. 6, 2017, 7:08 a.m. UTC
acpi_dev_pm_get_node() isn't used or implemented, let's remove it.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 include/linux/acpi.h | 5 -----
 1 file changed, 5 deletions(-)

Comments

Pavel Machek Oct. 6, 2017, 12:12 p.m. UTC | #1
On Fri 2017-10-06 09:08:34, Ulf Hansson wrote:
> acpi_dev_pm_get_node() isn't used or implemented, let's remove it.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel Machek Oct. 6, 2017, 12:14 p.m. UTC | #2
On Fri 2017-10-06 14:12:30, Pavel Machek wrote:
> On Fri 2017-10-06 09:08:34, Ulf Hansson wrote:
> > acpi_dev_pm_get_node() isn't used or implemented, let's remove it.
> > 
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

I was too quick sending this.

How is it unused?

./drivers/acpi/device_pm.c: * acpi_dev_pm_attach - Prepare device for
ACPI power management.
./drivers/acpi/device_pm.c:int acpi_dev_pm_attach(struct device *dev,
bool power_on)
./drivers/acpi/device_pm.c:EXPORT_SYMBOL_GPL(acpi_dev_pm_attach);
Binary file ./drivers/acpi/device_pm.o matches
Binary file ./drivers/base/power/common.o matches
./drivers/base/power/common.c:		  ret =
acpi_dev_pm_attach(dev, power_on);

									Pavel
Ulf Hansson Oct. 7, 2017, 6:44 a.m. UTC | #3
On 6 October 2017 at 14:14, Pavel Machek <pavel@ucw.cz> wrote:
> On Fri 2017-10-06 14:12:30, Pavel Machek wrote:
>> On Fri 2017-10-06 09:08:34, Ulf Hansson wrote:
>> > acpi_dev_pm_get_node() isn't used or implemented, let's remove it.
>> >
>> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>>
>> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> I was too quick sending this.
>
> How is it unused?
>
> ./drivers/acpi/device_pm.c: * acpi_dev_pm_attach - Prepare device for
> ACPI power management.
> ./drivers/acpi/device_pm.c:int acpi_dev_pm_attach(struct device *dev,
> bool power_on)
> ./drivers/acpi/device_pm.c:EXPORT_SYMBOL_GPL(acpi_dev_pm_attach);
> Binary file ./drivers/acpi/device_pm.o matches
> Binary file ./drivers/base/power/common.o matches
> ./drivers/base/power/common.c:            ret =
> acpi_dev_pm_attach(dev, power_on);

I think you searched for the wrong function. It should be
acpi_dev_pm_get_node().

Kind regards
Uffe
Rafael J. Wysocki Oct. 10, 2017, 4:55 p.m. UTC | #4
On Friday, October 6, 2017 9:08:34 AM CEST Ulf Hansson wrote:
> acpi_dev_pm_get_node() isn't used or implemented, let's remove it.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>  include/linux/acpi.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 502af53..3b89b4f 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -868,17 +868,12 @@ int acpi_dev_runtime_suspend(struct device *dev);
>  int acpi_dev_runtime_resume(struct device *dev);
>  int acpi_subsys_runtime_suspend(struct device *dev);
>  int acpi_subsys_runtime_resume(struct device *dev);
> -struct acpi_device *acpi_dev_pm_get_node(struct device *dev);
>  int acpi_dev_pm_attach(struct device *dev, bool power_on);
>  #else
>  static inline int acpi_dev_runtime_suspend(struct device *dev) { return 0; }
>  static inline int acpi_dev_runtime_resume(struct device *dev) { return 0; }
>  static inline int acpi_subsys_runtime_suspend(struct device *dev) { return 0; }
>  static inline int acpi_subsys_runtime_resume(struct device *dev) { return 0; }
> -static inline struct acpi_device *acpi_dev_pm_get_node(struct device *dev)
> -{
> -	return NULL;
> -}
>  static inline int acpi_dev_pm_attach(struct device *dev, bool power_on)
>  {
>  	return -ENODEV;
> 

Applied, thanks!

Patch
diff mbox

diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 502af53..3b89b4f 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -868,17 +868,12 @@  int acpi_dev_runtime_suspend(struct device *dev);
 int acpi_dev_runtime_resume(struct device *dev);
 int acpi_subsys_runtime_suspend(struct device *dev);
 int acpi_subsys_runtime_resume(struct device *dev);
-struct acpi_device *acpi_dev_pm_get_node(struct device *dev);
 int acpi_dev_pm_attach(struct device *dev, bool power_on);
 #else
 static inline int acpi_dev_runtime_suspend(struct device *dev) { return 0; }
 static inline int acpi_dev_runtime_resume(struct device *dev) { return 0; }
 static inline int acpi_subsys_runtime_suspend(struct device *dev) { return 0; }
 static inline int acpi_subsys_runtime_resume(struct device *dev) { return 0; }
-static inline struct acpi_device *acpi_dev_pm_get_node(struct device *dev)
-{
-	return NULL;
-}
 static inline int acpi_dev_pm_attach(struct device *dev, bool power_on)
 {
 	return -ENODEV;