| Message ID | 313f1c99-82f0-4433-b778-904856e6e333@default (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Looks good for me. Reviewed-by: Joe Jin <joe.jin@oracle.com> On 10/09/2017 02:00 PM, Zhenzhong Duan wrote: > Same code is already in allocate_and_map_msi_pirq() > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com> > --- > xen/arch/x86/physdev.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c > index 0eb4097..aa02d18 100644 > --- a/xen/arch/x86/physdev.c > +++ b/xen/arch/x86/physdev.c > @@ -122,8 +122,6 @@ int physdev_map_pirq(domid_t domid, int type, int *index, int *pirq_p, > break; > > case MAP_PIRQ_TYPE_MSI: > - if ( !msi->table_base ) > - msi->entry_nr = 1; > /* fallthrough */ > case MAP_PIRQ_TYPE_MULTI_MSI: > ret = allocate_and_map_msi_pirq(d, *index, pirq_p, type, msi); >
>>> On 09.10.17 at 08:00, <zhenzhong.duan@oracle.com> wrote: > --- a/xen/arch/x86/physdev.c > +++ b/xen/arch/x86/physdev.c > @@ -122,8 +122,6 @@ int physdev_map_pirq(domid_t domid, int type, int *index, int *pirq_p, > break; > > case MAP_PIRQ_TYPE_MSI: > - if ( !msi->table_base ) > - msi->entry_nr = 1; > /* fallthrough */ > case MAP_PIRQ_TYPE_MULTI_MSI: I have a variant of this (also removing the then stray comment) pending for after 4.10 (the change comes too later for 4.10). Please also don't forget to Cc maintainers when submitting patches. Jan
On Mon, Oct 09, 2017 at 06:00:15AM +0000, Zhenzhong Duan wrote: > Same code is already in allocate_and_map_msi_pirq() > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Whit one nit below. > --- > xen/arch/x86/physdev.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c > index 0eb4097..aa02d18 100644 > --- a/xen/arch/x86/physdev.c > +++ b/xen/arch/x86/physdev.c > @@ -122,8 +122,6 @@ int physdev_map_pirq(domid_t domid, int type, int *index, int *pirq_p, > break; > > case MAP_PIRQ_TYPE_MSI: > - if ( !msi->table_base ) > - msi->entry_nr = 1; > /* fallthrough */ Remove the fallthrough comment. > case MAP_PIRQ_TYPE_MULTI_MSI: > ret = allocate_and_map_msi_pirq(d, *index, pirq_p, type, msi); > -- > 1.7.3 > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel
On Mon, Oct 09, 2017 at 02:15:48PM +0800, Joe Jin wrote: > Looks good for me. > > Reviewed-by: Joe Jin <joe.jin@oracle.com> Ah, indeed. Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Also CC-ing Jan and Andrew. P.S. Could you change the title to have 'x86/physdev:' as part of the name please? > > On 10/09/2017 02:00 PM, Zhenzhong Duan wrote: > > Same code is already in allocate_and_map_msi_pirq() > > > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com> > > --- > > xen/arch/x86/physdev.c | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c > > index 0eb4097..aa02d18 100644 > > --- a/xen/arch/x86/physdev.c > > +++ b/xen/arch/x86/physdev.c > > @@ -122,8 +122,6 @@ int physdev_map_pirq(domid_t domid, int type, int *index, int *pirq_p, > > break; > > > > case MAP_PIRQ_TYPE_MSI: > > - if ( !msi->table_base ) > > - msi->entry_nr = 1; > > /* fallthrough */ > > case MAP_PIRQ_TYPE_MULTI_MSI: > > ret = allocate_and_map_msi_pirq(d, *index, pirq_p, type, msi); > > > > > -- > Oracle <http://www.oracle.com> > Joe Jin | Software Development Director | +8610.6106.5624 > ORACLE | Linux and Virtualization > No. 24 Zhongguancun Software Park, Haidian District | 100193 Beijing > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel
diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c index 0eb4097..aa02d18 100644 --- a/xen/arch/x86/physdev.c +++ b/xen/arch/x86/physdev.c @@ -122,8 +122,6 @@ int physdev_map_pirq(domid_t domid, int type, int *index, int *pirq_p, break; case MAP_PIRQ_TYPE_MSI: - if ( !msi->table_base ) - msi->entry_nr = 1; /* fallthrough */ case MAP_PIRQ_TYPE_MULTI_MSI: ret = allocate_and_map_msi_pirq(d, *index, pirq_p, type, msi);
Same code is already in allocate_and_map_msi_pirq() Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com> --- xen/arch/x86/physdev.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)