mbox series

[00/11] Add Recon3D support + Driver cleanup

Message ID 1533749663-8200-1-git-send-email-conmanx360@gmail.com (mailing list archive)
Headers show
Series Add Recon3D support + Driver cleanup | expand

Message

Connor McAdams Aug. 8, 2018, 5:34 p.m. UTC
This patch series adds support for the Recon3D PCI-E card. I have
personally tested it on a Recon3D that was sent to me, and included
that PCI ID in the quirk table.

Much of this patch series renames Recon3Di functions to just r3d
because both cards behave similarly.

Aside from that, I do have a question- If the PCI ID's are included in
the Window's driver .inf file, would I be good to add them in as
quirks? Or should I wait for someone with the card to test it, and
then add it once I know it works on that specific card?

Connor McAdams (11):
  ALSA: hda/ca0132 - Create mmio gpio function to make code clearer
  ALSA: hda/ca0132 - Clean up ca0132_init function.
  ALSA: hda/ca0132 - Add alt_functions unsolicited response
  ALSA: hda/ca0132 - Add quirk ID and enum for Recon3D
  ALSA: hda/ca0132 - Add Recon3D pincfg
  ALSA: hda/ca0132 - Add bool variable to enable/disable pci region2
    mmio
  ALSA: hda/ca0132 - Add Recon3D startup functions and setup
  ALSA: hda/ca0132 - Add DSP setup defaults for Recon3D
  ALSA: hda/ca0132 - Add Recon3D input and output select commands
  ALSA: hda/ca0132 - Change mixer controls for Recon3D
  ALSA: hda/ca0132 - Add exit commands for Recon3D

 sound/pci/hda/patch_ca0132.c | 276 ++++++++++++++++++++++++++++---------------
 1 file changed, 180 insertions(+), 96 deletions(-)

Comments

Takashi Iwai Aug. 8, 2018, 6:43 p.m. UTC | #1
On Wed, 08 Aug 2018 19:34:11 +0200,
Connor McAdams wrote:
> 
> This patch series adds support for the Recon3D PCI-E card. I have
> personally tested it on a Recon3D that was sent to me, and included
> that PCI ID in the quirk table.
> 
> Much of this patch series renames Recon3Di functions to just r3d
> because both cards behave similarly.

All patches look well cooked.  I applied all 11 patches now.

> Aside from that, I do have a question- If the PCI ID's are included in
> the Window's driver .inf file, would I be good to add them in as
> quirks? Or should I wait for someone with the card to test it, and
> then add it once I know it works on that specific card?

Such a decision depends on the situation, and in the case of CA0132,
we can take them, I suppose.  The boards don't work properly without
the explicit fixes, so it can't be worse, after all :)


Thanks!

Takashi