| Message ID | 1538276607-30234-1-git-send-email-conmanx360@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add ZxR support + bugfixes | expand |
Hi, On Sep 30 2018 12:03, Connor McAdams wrote: > This patch series adds support for the Sound Blaster ZxR, as well as a > few bug fixes. This should be the last ca0132 based Creative card that > needed support to be added. > > Also, I did check to make sure each patch compiles properly this time, > but you can check yourself just to be sure. :) > > Connor McAdams (11): > ALSA: hda/ca0132 - Fix AE-5 control type > ALSA: hda/ca0132 - Fix surround sound with output effects > ALSA: hda/ca0132 - Add ZxR quirks + new quirk check function > ALSA: hda/ca0132 - Add ZxR pincfg > ALSA: hda/ca0132 - Add DBpro hda_codec_ops > ALSA: hda/ca0132 - Add ZxR init commands > ALSA: hda/ca0132 - Add ZxR DSP post-download commands > ALSA: hda/ca0132 - Add ZxR input/output select commands > ALSA: hda/ca0132 - Remove input select enum for ZxR > ALSA: hda/ca0132 - Add ZxR 600 ohm gain control > ALSA: hda/ca0132 - Add ZxR exit commands > > sound/pci/hda/patch_ca0132.c | 369 ++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 345 insertions(+), 24 deletions(-) I reviewed the above patches and they looks good to be merged to upstream. Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> I've already point some nitpickings but they can be solved after merging them till next merge window. Thanks Takashi Sakamoto
On Sun, 30 Sep 2018 05:03:15 +0200, Connor McAdams wrote: > > This patch series adds support for the Sound Blaster ZxR, as well as a > few bug fixes. This should be the last ca0132 based Creative card that > needed support to be added. > > Also, I did check to make sure each patch compiles properly this time, > but you can check yourself just to be sure. :) > > Connor McAdams (11): > ALSA: hda/ca0132 - Fix AE-5 control type > ALSA: hda/ca0132 - Fix surround sound with output effects > ALSA: hda/ca0132 - Add ZxR quirks + new quirk check function > ALSA: hda/ca0132 - Add ZxR pincfg > ALSA: hda/ca0132 - Add DBpro hda_codec_ops > ALSA: hda/ca0132 - Add ZxR init commands > ALSA: hda/ca0132 - Add ZxR DSP post-download commands > ALSA: hda/ca0132 - Add ZxR input/output select commands > ALSA: hda/ca0132 - Remove input select enum for ZxR > ALSA: hda/ca0132 - Add ZxR 600 ohm gain control > ALSA: hda/ca0132 - Add ZxR exit commands Now applied all 11 patches (with Sakamoto-san's Reviewed-by tags). Thanks! Takashi
I have fixed the microphone issue, and will try to get the patches written by the end of the week so they can be in the next kernel (at least I think that's what Takashi Sakamoto said, two weeks from 7 days ago). With the two suggestions by Takashi Sakamoto, do I need those in order for it to be merged? I will work on them regardless, but with those it may take me longer (they might be simple, I haven't dug into what they require yet). Let me know. Thanks, Connor. On Tue, Oct 2, 2018 at 11:23 AM Takashi Iwai <tiwai@suse.de> wrote: > > On Sun, 30 Sep 2018 05:03:15 +0200, > Connor McAdams wrote: > > > > This patch series adds support for the Sound Blaster ZxR, as well as a > > few bug fixes. This should be the last ca0132 based Creative card that > > needed support to be added. > > > > Also, I did check to make sure each patch compiles properly this time, > > but you can check yourself just to be sure. :) > > > > Connor McAdams (11): > > ALSA: hda/ca0132 - Fix AE-5 control type > > ALSA: hda/ca0132 - Fix surround sound with output effects > > ALSA: hda/ca0132 - Add ZxR quirks + new quirk check function > > ALSA: hda/ca0132 - Add ZxR pincfg > > ALSA: hda/ca0132 - Add DBpro hda_codec_ops > > ALSA: hda/ca0132 - Add ZxR init commands > > ALSA: hda/ca0132 - Add ZxR DSP post-download commands > > ALSA: hda/ca0132 - Add ZxR input/output select commands > > ALSA: hda/ca0132 - Remove input select enum for ZxR > > ALSA: hda/ca0132 - Add ZxR 600 ohm gain control > > ALSA: hda/ca0132 - Add ZxR exit commands > > Now applied all 11 patches (with Sakamoto-san's Reviewed-by tags). > Thanks! > > > Takashi
On Sun, 07 Oct 2018 19:05:07 +0200, Connor McAdams wrote: > > I have fixed the microphone issue, and will try to get the patches > written by the end of the week so they can be in the next kernel (at > least I think that's what Takashi Sakamoto said, two weeks from 7 days > ago). With the two suggestions by Takashi Sakamoto, do I need those in > order for it to be merged? I will work on them regardless, but with > those it may take me longer (they might be simple, I haven't dug into > what they require yet). It's basically up to you. I can merge all of them in a shot if they are relevant, or merge each of them gradually if they are irrelevant with each other. thanks, Takashi > > Let me know. > > Thanks, > Connor. > On Tue, Oct 2, 2018 at 11:23 AM Takashi Iwai <tiwai@suse.de> wrote: > > > > On Sun, 30 Sep 2018 05:03:15 +0200, > > Connor McAdams wrote: > > > > > > This patch series adds support for the Sound Blaster ZxR, as well as a > > > few bug fixes. This should be the last ca0132 based Creative card that > > > needed support to be added. > > > > > > Also, I did check to make sure each patch compiles properly this time, > > > but you can check yourself just to be sure. :) > > > > > > Connor McAdams (11): > > > ALSA: hda/ca0132 - Fix AE-5 control type > > > ALSA: hda/ca0132 - Fix surround sound with output effects > > > ALSA: hda/ca0132 - Add ZxR quirks + new quirk check function > > > ALSA: hda/ca0132 - Add ZxR pincfg > > > ALSA: hda/ca0132 - Add DBpro hda_codec_ops > > > ALSA: hda/ca0132 - Add ZxR init commands > > > ALSA: hda/ca0132 - Add ZxR DSP post-download commands > > > ALSA: hda/ca0132 - Add ZxR input/output select commands > > > ALSA: hda/ca0132 - Remove input select enum for ZxR > > > ALSA: hda/ca0132 - Add ZxR 600 ohm gain control > > > ALSA: hda/ca0132 - Add ZxR exit commands > > > > Now applied all 11 patches (with Sakamoto-san's Reviewed-by tags). > > Thanks! > > > > > > Takashi >