mbox series

[0/4] Various cleanup + Mic Fix

Message ID 1539027601-20910-1-git-send-email-conmanx360@gmail.com (mailing list archive)
Headers show
Series Various cleanup + Mic Fix | expand

Message

Connor McAdams Oct. 8, 2018, 7:39 p.m. UTC 
This patch set fixes the microphone inconsistency issue, which means
the microphone now works all the time on all of the cards I've tested
(ZxR, Z, AE-5), along with the input effects.

It also includes changes suggested by Takashi Sakamoto, I believe I did
what he asked properly, but if I messed it up I'm sure you guys will
let me know.

This should finish up most of the ca0132 work, with all inputs and
outputs working on the desktop cards.

Connor McAdams (4):
  ALSA: hda/ca0132 - Fix microphone inconsistency issues
  ALSA: hda/ca0132 - Clean up patch_ca0132()
  ALSA: hda/ca0132 - Add error checking in ca0132_build_controls()
  ALSA: hda/ca0132 - Fix input effect controls for desktop cards

 sound/pci/hda/patch_ca0132.c | 75 +++++++++++++++++++++++++++++++-------------
 1 file changed, 54 insertions(+), 21 deletions(-)

Comments

Takashi Sakamoto Oct. 9, 2018, 2:15 p.m. UTC | #1 
On 2018年10月09日 04:39, Connor McAdams wrote:
> This patch set fixes the microphone inconsistency issue, which means
> the microphone now works all the time on all of the cards I've tested
> (ZxR, Z, AE-5), along with the input effects.
> 
> It also includes changes suggested by Takashi Sakamoto, I believe I did
> what he asked properly, but if I messed it up I'm sure you guys will
> let me know.
> 
> This should finish up most of the ca0132 work, with all inputs and
> outputs working on the desktop cards.
> 
> Connor McAdams (4):
>    ALSA: hda/ca0132 - Fix microphone inconsistency issues
>    ALSA: hda/ca0132 - Clean up patch_ca0132()
>    ALSA: hda/ca0132 - Add error checking in ca0132_build_controls()
>    ALSA: hda/ca0132 - Fix input effect controls for desktop cards
> 
>   sound/pci/hda/patch_ca0132.c | 75 +++++++++++++++++++++++++++++++-------------
>   1 file changed, 54 insertions(+), 21 deletions(-)

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>


Thanks

Takashi Sakamoto
Takashi Iwai Oct. 9, 2018, 2:21 p.m. UTC | #2 
On Mon, 08 Oct 2018 21:39:56 +0200,
Connor McAdams wrote:
> 
> This patch set fixes the microphone inconsistency issue, which means
> the microphone now works all the time on all of the cards I've tested
> (ZxR, Z, AE-5), along with the input effects.
> 
> It also includes changes suggested by Takashi Sakamoto, I believe I did
> what he asked properly, but if I messed it up I'm sure you guys will
> let me know.
> 
> This should finish up most of the ca0132 work, with all inputs and
> outputs working on the desktop cards.
> 
> Connor McAdams (4):
>   ALSA: hda/ca0132 - Fix microphone inconsistency issues
>   ALSA: hda/ca0132 - Clean up patch_ca0132()
>   ALSA: hda/ca0132 - Add error checking in ca0132_build_controls()
>   ALSA: hda/ca0132 - Fix input effect controls for desktop cards

Now applied all four patches.  Thanks.


Takashi