[v4,0/4] ASoC: fsl: audmix: remove "model" attribute and fix ref leaks

Message

Viorel Suman April 10, 2019, 11:06 a.m. UTC

The latest audmix patch-set (v5) had the "model" attribute removed as
requested by Nicolin Chen, but looks like (v4) version of DAI driver
reached "for-next" branch - fix this by removing "model" attribute.
Asside of this fix object reference leaks in machine probe reported by
Julia Lawall.

Viorel Suman (4):
  ASoC: fsl_audmix: remove "model" attribute
  ASoC: fsl_audmix: remove "model" attribute from DT document
  ASoC: imx-audmix: fix object reference leaks in probe
  ASoC: fsl_audmix: cache pdev->dev pointer

Changes since V1:
  a) Removed "model" attribute from dt-bindings documentation
  b) Adressed Daniel's comments

Changes since V2:
  a) Cache pdev->dev pointer in fsl_audmix probe as suggested by Nicolin

Changes since V3:
  a) Use subject lines matching the style for the subsystem.

 .../devicetree/bindings/sound/fsl,audmix.txt       |  4 --
 sound/soc/fsl/fsl_audmix.c                         | 60 +++++++++++-----------
 sound/soc/fsl/imx-audmix.c                         |  4 ++
 3 files changed, 35 insertions(+), 33 deletions(-)

Comments

Mark Brown April 10, 2019, 11:12 a.m. UTC | #1

On Wed, Apr 10, 2019 at 11:06:35AM +0000, Viorel Suman wrote:
> The latest audmix patch-set (v5) had the "model" attribute removed as
> requested by Nicolin Chen, but looks like (v4) version of DAI driver
> reached "for-next" branch - fix this by removing "model" attribute.
> Asside of this fix object reference leaks in machine probe reported by
> Julia Lawall.

This is the second version sent out in the past hour or so :(  Please
allow a bit more time for review and comments, people might still be
looking at the earlier versions so any additional changes they spot will
result in yet another resend and more noise in people's inboxes.