mbox series

[0/2] v2 pcm_file propagate write error instead of an assert

Message ID 1560322108-17074-1-git-send-email-amiartus@de.adit-jv.com (mailing list archive)
Headers show
Series v2 pcm_file propagate write error instead of an assert | expand

Message

Adam Miartus June 12, 2019, 6:48 a.m. UTC 
patch possible case whenre file write causes assert in pcm_file
plugin, by reporting error to user and printing a message

user has a chance to recover error state, or capture
correct logs before assert happens, and may have an idea how
to recover

Adam Miartus (2):
  pcm_file: do not disrupt playback on output file write fail
  pcm_file: report write output file error to api user

 src/pcm/pcm_file.c | 61 ++++++++++++++++++++++++++++++++++++++----------------
 1 file changed, 43 insertions(+), 18 deletions(-)

Comments

Takashi Iwai June 15, 2019, 8:35 a.m. UTC | #1 
On Wed, 12 Jun 2019 08:48:26 +0200,
Adam Miartus wrote:
> 
> patch possible case whenre file write causes assert in pcm_file
> plugin, by reporting error to user and printing a message
> 
> user has a chance to recover error state, or capture
> correct logs before assert happens, and may have an idea how
> to recover
> 
> Adam Miartus (2):
>   pcm_file: do not disrupt playback on output file write fail
>   pcm_file: report write output file error to api user

Applied both patches.  Thanks.


Takashi
Takashi Iwai June 18, 2019, 6:30 a.m. UTC | #2 
On Wed, 12 Jun 2019 08:48:26 +0200,
Adam Miartus wrote:
> 
> patch possible case whenre file write causes assert in pcm_file
> plugin, by reporting error to user and printing a message
> 
> user has a chance to recover error state, or capture
> correct logs before assert happens, and may have an idea how
> to recover
> 
> Adam Miartus (2):
>   pcm_file: do not disrupt playback on output file write fail
>   pcm_file: report write output file error to api user

The patches have been already merged.  Any reason for resend?


thanks,

Takashi
Adam Miartus June 18, 2019, 6:49 a.m. UTC | #3 
> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Dienstag, 18. Juni 2019 08:31
> To: Miartus, Adam (Arion Recruitment; ADITG/ESM) <amiartus@de.adit-
> jv.com>
> Cc: alsa-devel@alsa-project.org
> Subject: Re: [ALSA patch] [PATCH 0/2] v2 pcm_file propagate write error
> instead of an assert
> 
> On Wed, 12 Jun 2019 08:48:26 +0200,
> Adam Miartus wrote:
> >
> > patch possible case whenre file write causes assert in pcm_file
> > plugin, by reporting error to user and printing a message
> >
> > user has a chance to recover error state, or capture
> > correct logs before assert happens, and may have an idea how
> > to recover
> >
> > Adam Miartus (2):
> >   pcm_file: do not disrupt playback on output file write fail
> >   pcm_file: report write output file error to api user
> 
> The patches have been already merged.  Any reason for resend?
> 
> 
> thanks,
> 
> Takashi

This is request v2, Im not aware I sent it two times. If so, sorry for spam.