| Message ID | 1593233625-14961-1-git-send-email-spujar@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for Tegra210 Audio | expand |
On Sat, Jun 27, 2020 at 10:23:22AM +0530, Sameer Pujar wrote: > Following is the summary of current series. > * Add YAML DT binding documentation for above mentioned modules. > * Helper function for ACIF programming is exposed for Tegra210 and later. > * Add ASoC driver components for each of the above modules. > * Add DT entries for above components for Tegra210, Tegra186 and > Tegra194. > * Enable these components for Jetson Nano/TX1/TX2/Xavier > * Enhance simple-card DPCM driver to suit Tegra Audio applications with > few changes in core. > * To begin with, enable sound card support for Tegra210 based platforms > like Jetson Nano/TX1. This series is too big and covers a few different topics which makes it difficult to manage, please split it up. The most obvious thing here is that it contains both the drivers you're adding and a bunch of changes to the generic audio cards (which are a single throwaway line in your cover letter) - splitting out the generic card changes into a separate series would result in more manageable sizes.
On 6/30/2020 4:21 PM, Mark Brown wrote: > On Sat, Jun 27, 2020 at 10:23:22AM +0530, Sameer Pujar wrote: > >> Following is the summary of current series. >> * Add YAML DT binding documentation for above mentioned modules. >> * Helper function for ACIF programming is exposed for Tegra210 and later. >> * Add ASoC driver components for each of the above modules. >> * Add DT entries for above components for Tegra210, Tegra186 and >> Tegra194. >> * Enable these components for Jetson Nano/TX1/TX2/Xavier >> * Enhance simple-card DPCM driver to suit Tegra Audio applications with >> few changes in core. >> * To begin with, enable sound card support for Tegra210 based platforms >> like Jetson Nano/TX1. > This series is too big and covers a few different topics which makes it > difficult to manage, please split it up. The most obvious thing here is > that it contains both the drivers you're adding and a bunch of changes > to the generic audio cards (which are a single throwaway line in your > cover letter) - splitting out the generic card changes into a separate > series would result in more manageable sizes. My initial thought was, it would be better to present a entire picture where complete audio path can be tested or reviewed and hence added simple-card patches in the series. I will split this up in next revision.
Overview ======== Audio Processing Engine (APE) comprises of Audio DMA (ADMA) and Audio Hub (AHUB) unit. AHUB is a collection of hardware accelerators for audio pre-processing and post-processing. It also includes a programmable full crossbar for routing audio data across these accelerators. This series exposes some of these below mentioned HW devices as ASoC components for Tegra platforms from Tegra210 onwards. * ADMAIF : The interface between ADMA and AHUB * XBAR : Crossbar for routing audio samples across various modules * I2S : Inter-IC Sound Controller * DMIC : Digital Microphone * DSPK : Digital Speaker Following is the summary of current series. * Add YAML DT binding documentation for above mentioned modules. * Helper function for ACIF programming is exposed for Tegra210 and later. * Add ASoC driver components for each of the above modules. * Add DT entries for above components for Tegra210, Tegra186 and Tegra194. * Enable these components for Jetson Nano/TX1/TX2/Xavier * Enhance simple-card DPCM driver to suit Tegra Audio applications with few changes in core. * To begin with, enable sound card support for Tegra210 based platforms like Jetson Nano/TX1. Sound card support for platforms based on Tegra186 and later will be subsequently added which can re-use all of the above components. Changelog ========= v3 -> v4 -------- * [1/23] "ASoC: dt-bindings: tegra: Add DT bindings for Tegra210" - Removed multiple examples and retained one example per doc - Fixed as per inputs on the previous series - Tested bindings with 'make dt_binding_check/dtbs_check' * [2/23] "ASoC: tegra: Add support for CIF programming" - No change * Common changes (for patch [3/10] to [7/10]) - Mixer control overrides, for PCM parameters (rate, channel, bits), in each driver are dropped. - Updated routing as per DPCM usage - Minor changes related to formatting * New changes (patch [8/23] to [18/23] and patch [23/23]) - Based on discussions in following threads DPCM is used for Tegra Audio. https://lkml.org/lkml/2020/2/20/91 https://lkml.org/lkml/2020/4/30/519 - The simple-card driver is used for Tegra Audio and accordingly some enhancements are made in simple-card and core drivers. - Patch [8/23] to [18/23] are related to simple-card and core changes. - Patch [23/23] adds sound card support to realize complete audio path. This is based on simple-card driver with proposed enhancements. - Re-ordered patches depending on above v2 -> v3 -------- * [1/10] "dt-bindings: sound: tegra: add DT binding for AHUB - Updated licence - Removed redundancy w.r.t items/const/enum - Added constraints wherever needed with "pattern" property * [2/10] "ASoC: tegra: add support for CIF programming" - Removed tegra_cif.c - Instead added inline helper function in tegra_cif.h * common changes (for patch [3/10] to [7/10]) - Replace LATE system calls with Normal sleep - Remove explicit RPM suspend in driver remove() call - Use devm_kzalloc() instead of devm_kcalloc() for single element - Replace 'ret' with 'err' for better reading - Consistent error printing style across drivers - Minor formating fixes * [8/10] "arm64: tegra: add AHUB components for few Tegra chips" - no change * [9/10] "arm64: tegra: enable AHUB modules for few Tegra chips" - no change * [10/10] "arm64: defconfig: enable AHUB components for Tegra210 and later" (New patch) - Enables ACONNECT and AHUB components. With this AHUB and components are registered with ASoC core. v1 -> v2 -------- * [1/9] "dt-bindings: sound: tegra: add DT binding for AHUB" - no changes * [2/9] "ASoC: tegra: add support for CIF programming" - removed CIF programming changes for legacy chips. - this patch now exposes helper function for CIF programming, which can be used on Tegra210 later. - later tegra_cif.c can be extended for legacy chips as well. - updated commit message accordingly * [3/9] "ASoC: tegra: add Tegra210 based DMIC driver" - removed unnecessary initialization of 'ret' in probe() * [4/9] "ASoC: tegra: add Tegra210 based I2S driver" - removed unnecessary initialization of 'ret' in probe() - fixed indentation - added consistent bracing for if-else clauses - updated 'rx_fifo_th' type to 'unsigned int' - used BIT() macro for defines like '1 << {x}' in tegra210_i2s.h * [5/9] "ASoC: tegra: add Tegra210 based AHUB driver" - used of_device_get_match_data() to get 'soc_data' and removed explicit of_match_device() - used devm_platform_ioremap_resource() and removed explicit platform_get_resource() - fixed indentation for devm_snd_soc_register_component() - updated commit message - updated commit message to reflect compatible binding for Tegra186 and Tegra194. * [6/9] "ASoC: tegra: add Tegra186 based DSPK driver" - removed unnecessary initialization of 'ret' in probe() - updated 'max_th' to 'unsigned int' - shortened lengthy macro names to avoid wrapping in tegra186_dspk_wr_reg() and to be consistent * [7/9] "ASoC: tegra: add Tegra210 based ADMAIF driver" - used of_device_get_match_data() and removed explicit of_match_device() - used BIT() macro for defines like '1 << {x}' in tegra210_admaif.h - updated commit message to reflect compatible binding for Tegra186 and Tegra194. * [8/9] "arm64: tegra: add AHUB components for few Tegra chips" - no change * [9/9] "arm64: tegra: enable AHUB modules for few Tegra chips" - no change * common changes for patch [3/9] to [7/9] - sorted headers in alphabetical order - moved MODULE_DEVICE_TABLE() right below *_of_match table - removed macro DRV_NAME - removed explicit 'owner' field from platform_driver structure - added 'const' to snd_soc_dai_ops structure ================== Sameer Pujar (23): ASoC: dt-bindings: tegra: Add DT bindings for Tegra210 ASoC: tegra: Add support for CIF programming ASoC: tegra: Add Tegra210 based DMIC driver ASoC: tegra: Add Tegra210 based I2S driver ASoC: tegra: Add Tegra210 based AHUB driver ASoC: tegra: Add Tegra186 based DSPK driver ASoC: tegra: Add Tegra210 based ADMAIF driver ASoC: soc-core: Fix component name_prefix parsing ASoC: simple-card: Use of_node and DAI names for DAI link names ASoC: simple-card: Wrong daifmt for CPU end of DPCM DAI link ASoC: simple-card: Loop over all children for 'mclk-fs' ASoC: simple-card: Support DPCM DAI link with multiple Codecs ASoC: simple-card: DPCM DAI link direction as per DAI capability ASoC: soc-core: Probe auxiliary component before others ASoC: soc-core: Identify 'no_pcm' DAI links for DPCM ASoC: soc-pcm: Get all BEs along DAPM path ASoC: dt-bindings: simple-card: Add compatible for component chaining ASoC: simple-card: Add support for component chaining arm64: defconfig: Build AHUB component drivers arm64: defconfig: Enable CONFIG_TEGRA210_ADMA arm64: tegra: Add DT binding for AHUB components arm64: tegra: Enable AHUB components on few Tegra platforms arm64: tegra: Add support for APE sound card on Jetson Nano and TX1 .../bindings/sound/nvidia,tegra186-dspk.yaml | 88 +++ .../bindings/sound/nvidia,tegra210-admaif.yaml | 116 +++ .../bindings/sound/nvidia,tegra210-ahub.yaml | 144 ++++ .../bindings/sound/nvidia,tegra210-dmic.yaml | 88 +++ .../bindings/sound/nvidia,tegra210-i2s.yaml | 106 +++ .../devicetree/bindings/sound/simple-card.yaml | 1 + arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 48 ++ arch/arm64/boot/dts/nvidia/tegra186.dtsi | 231 +++++- arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 36 + arch/arm64/boot/dts/nvidia/tegra194.dtsi | 239 +++++- arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 136 +++- arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts | 85 +++ arch/arm64/boot/dts/nvidia/tegra210.dtsi | 219 +++++- arch/arm64/configs/defconfig | 8 + include/sound/simple_card.h | 5 + include/sound/soc.h | 3 + sound/soc/generic/simple-card.c | 96 ++- sound/soc/soc-core.c | 43 +- sound/soc/soc-dai.c | 1 + sound/soc/soc-pcm.c | 3 +- sound/soc/tegra/Kconfig | 56 ++ sound/soc/tegra/Makefile | 10 + sound/soc/tegra/tegra186_dspk.c | 427 +++++++++++ sound/soc/tegra/tegra186_dspk.h | 70 ++ sound/soc/tegra/tegra210_admaif.c | 845 +++++++++++++++++++++ sound/soc/tegra/tegra210_admaif.h | 162 ++++ sound/soc/tegra/tegra210_ahub.c | 578 ++++++++++++++ sound/soc/tegra/tegra210_ahub.h | 100 +++ sound/soc/tegra/tegra210_dmic.c | 440 +++++++++++ sound/soc/tegra/tegra210_dmic.h | 82 ++ sound/soc/tegra/tegra210_i2s.c | 780 +++++++++++++++++++ sound/soc/tegra/tegra210_i2s.h | 126 +++ sound/soc/tegra/tegra_cif.h | 65 ++ sound/soc/tegra/tegra_pcm.c | 235 +++++- sound/soc/tegra/tegra_pcm.h | 21 +- 35 files changed, 5657 insertions(+), 36 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml create mode 100644 sound/soc/tegra/tegra186_dspk.c create mode 100644 sound/soc/tegra/tegra186_dspk.h create mode 100644 sound/soc/tegra/tegra210_admaif.c create mode 100644 sound/soc/tegra/tegra210_admaif.h create mode 100644 sound/soc/tegra/tegra210_ahub.c create mode 100644 sound/soc/tegra/tegra210_ahub.h create mode 100644 sound/soc/tegra/tegra210_dmic.c create mode 100644 sound/soc/tegra/tegra210_dmic.h create mode 100644 sound/soc/tegra/tegra210_i2s.c create mode 100644 sound/soc/tegra/tegra210_i2s.h create mode 100644 sound/soc/tegra/tegra_cif.h