| Message ID | 1602859382-19505-1-git-send-email-spujar@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Audio graph card updates and usage with Tegra210 audio | expand |
Hi Mark, Morimoto-san, > Summary of changes: > * Support multiple instances of a component. For example there can be > multiple I2S devices which can use the same component driver. > > * Support open platforms with empty Codec endpoint. Customers can plug > their own HW and can populate codec endpoint. > > * In a component model there can be many components which can be > connected togethe. In such cases Identify no-pcm DPCM DAI links which > can be used in BE<->BE connections. > > * Add Tegra audio graph driver which is based on generic audio graph > driver and specific customizations are done in Tegra driver. > > * This pushes DT support for Tegra210 based platforms which uses > audio-graph card and above enhancements. > > The series is based on following references where DPCM usgae for Tegra > Audio and simple-card driver proposal were discussed. > > * https://lkml.org/lkml/2020/4/30/519 (DPCM for Tegra) > * https://lkml.org/lkml/2020/6/27/4 (simple-card driver) > > Changelog > ========= > > v3 -> v4 > -------- > * Added new patches to convert graph.txt and audio-graph-card.txt > to corresponding json-schema files. Later these references > are used in Tegra audio graph schema. > > * AHUB component binding docs are updated to reflect the usage > of ports/port/endpoint > > * More common stuff is moved into graph_parse_of() and this is > used by both generic and Tegra audio graph. > > * DT binding for Tegra audio graph is updated to included "ports { }" > > * As per the suggestion 'void *data' member is dropped from > 'asoc_simple_priv' and instead container method is used to > maintain required custom data internal to Tegra audio graph. > > v2 -> v3 > -------- > * Dropped new compatible addition in generic graph driver > after reviewing it with Morimoto-san. Instead added Tegra > audio graph driver and new compatibles are added in the same. > * Added new patches to expose new members for customization > in audio graph driver. > * Added new patch for Tegra audio graph driver and related > documentation. > * Minor change in below commit where mutex version of helper is used > "ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM" > * DT binding is updated to use the newly exposed compatibles > * No changes in other patches > > v1 -> v2 > -------- > * Re-organized ports/endpoints description for ADMAIF and XBAR. > Updated DT patches accordingly. > * After above change, multiple Codec endpoint support is not > required and hence dropped for now. This will be considered > separately if at all required in future. > * Re-ordered patches in the series. > > Sameer Pujar (15): > ASoC: soc-core: Fix component name_prefix parsing > ASoC: soc-pcm: Get all BEs along DAPM path > ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names > ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM > ASoC: audio-graph: Support empty Codec endpoint > ASoC: audio-graph: Expose new members for asoc_simple_priv > ASoC: audio-graph: Expose helpers from audio graph Would you suggest to keep above in a separate series and thus not blocked by below doc updates? If so do I need to resend above in a next revision or if these are good to be picked up? > Documentation: of: Convert graph bindings to json-schema > ASoC: dt-bindings: audio-graph: Convert bindings to json-schema > ASoC: dt-bindings: tegra: Add graph bindings > ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card Documentation patches in the series have some dependency over Morimoto-san's audio-graph series https://patchwork.kernel.org/project/alsa-devel/list/?series=372759. I will update doc related patches once dependency is merged. > ASoC: tegra: Add audio graph based card driver > arm64: defconfig: Enable Tegra audio graph card driver > arm64: tegra: Audio graph header for Tegra210 > arm64: tegra: Audio graph sound card for Jetson Nano and TX1
On Fri, Oct 30, 2020 at 12:04:50PM +0530, Sameer Pujar wrote: > Hi Mark, Morimoto-san, > > Sameer Pujar (15): > > ASoC: soc-core: Fix component name_prefix parsing > > ASoC: soc-pcm: Get all BEs along DAPM path > > ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names > > ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM > > ASoC: audio-graph: Support empty Codec endpoint > > ASoC: audio-graph: Expose new members for asoc_simple_priv > > ASoC: audio-graph: Expose helpers from audio graph > Would you suggest to keep above in a separate series and thus not blocked by > below doc updates? If so do I need to resend above in a next revision or if > these are good to be picked up? It's probably better to split things up given that the dependencies for the last bit are on another series.
Summary of changes: * Support multiple instances of a component. For example there can be multiple I2S devices which can use the same component driver. * Support open platforms with empty Codec endpoint. Customers can plug their own HW and can populate codec endpoint. * In a component model there can be many components which can be connected togethe. In such cases Identify no-pcm DPCM DAI links which can be used in BE<->BE connections. * Add Tegra audio graph driver which is based on generic audio graph driver and specific customizations are done in Tegra driver. * This pushes DT support for Tegra210 based platforms which uses audio-graph card and above enhancements. The series is based on following references where DPCM usgae for Tegra Audio and simple-card driver proposal were discussed. * https://lkml.org/lkml/2020/4/30/519 (DPCM for Tegra) * https://lkml.org/lkml/2020/6/27/4 (simple-card driver) Changelog ========= v3 -> v4 -------- * Added new patches to convert graph.txt and audio-graph-card.txt to corresponding json-schema files. Later these references are used in Tegra audio graph schema. * AHUB component binding docs are updated to reflect the usage of ports/port/endpoint * More common stuff is moved into graph_parse_of() and this is used by both generic and Tegra audio graph. * DT binding for Tegra audio graph is updated to included "ports { }" * As per the suggestion 'void *data' member is dropped from 'asoc_simple_priv' and instead container method is used to maintain required custom data internal to Tegra audio graph. v2 -> v3 -------- * Dropped new compatible addition in generic graph driver after reviewing it with Morimoto-san. Instead added Tegra audio graph driver and new compatibles are added in the same. * Added new patches to expose new members for customization in audio graph driver. * Added new patch for Tegra audio graph driver and related documentation. * Minor change in below commit where mutex version of helper is used "ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM" * DT binding is updated to use the newly exposed compatibles * No changes in other patches v1 -> v2 -------- * Re-organized ports/endpoints description for ADMAIF and XBAR. Updated DT patches accordingly. * After above change, multiple Codec endpoint support is not required and hence dropped for now. This will be considered separately if at all required in future. * Re-ordered patches in the series. Sameer Pujar (15): ASoC: soc-core: Fix component name_prefix parsing ASoC: soc-pcm: Get all BEs along DAPM path ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM ASoC: audio-graph: Support empty Codec endpoint ASoC: audio-graph: Expose new members for asoc_simple_priv ASoC: audio-graph: Expose helpers from audio graph Documentation: of: Convert graph bindings to json-schema ASoC: dt-bindings: audio-graph: Convert bindings to json-schema ASoC: dt-bindings: tegra: Add graph bindings ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card ASoC: tegra: Add audio graph based card driver arm64: defconfig: Enable Tegra audio graph card driver arm64: tegra: Audio graph header for Tegra210 arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Documentation/devicetree/bindings/graph.txt | 128 ----- Documentation/devicetree/bindings/graph.yaml | 170 +++++++ .../devicetree/bindings/sound/audio-graph-card.txt | 337 ------------- .../bindings/sound/audio-graph-card.yaml | 548 +++++++++++++++++++++ .../sound/nvidia,tegra-audio-graph-card.yaml | 158 ++++++ .../bindings/sound/nvidia,tegra186-dspk.yaml | 7 + .../bindings/sound/nvidia,tegra210-admaif.yaml | 7 + .../bindings/sound/nvidia,tegra210-ahub.yaml | 7 + .../bindings/sound/nvidia,tegra210-dmic.yaml | 7 + .../bindings/sound/nvidia,tegra210-i2s.yaml | 7 + .../boot/dts/nvidia/tegra210-audio-graph.dtsi | 153 ++++++ arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 262 ++++++++++ arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts | 146 ++++++ arch/arm64/configs/defconfig | 1 + include/sound/graph_card.h | 16 + include/sound/simple_card_utils.h | 3 + include/sound/soc.h | 1 + sound/soc/generic/audio-graph-card.c | 175 ++++--- sound/soc/soc-core.c | 3 +- sound/soc/soc-pcm.c | 3 +- sound/soc/tegra/Kconfig | 9 + sound/soc/tegra/Makefile | 2 + sound/soc/tegra/tegra_audio_graph_card.c | 255 ++++++++++ 23 files changed, 1882 insertions(+), 523 deletions(-) delete mode 100644 Documentation/devicetree/bindings/graph.txt create mode 100644 Documentation/devicetree/bindings/graph.yaml delete mode 100644 Documentation/devicetree/bindings/sound/audio-graph-card.txt create mode 100644 Documentation/devicetree/bindings/sound/audio-graph-card.yaml create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-audio-graph.dtsi create mode 100644 include/sound/graph_card.h create mode 100644 sound/soc/tegra/tegra_audio_graph_card.c