mbox series

[0/6] ASoC: PCM format type conversion fixes

Message ID 20180725211722.18944-1-tiwai@suse.de (mailing list archive)
Headers show
Series ASoC: PCM format type conversion fixes | expand

Message

Takashi Iwai July 25, 2018, 9:17 p.m. UTC 
Hi,

the PCM format is a fixed type with __bitwise, and it needs cast or
other trick to deal with integer.  This is a series of such fixes for
ASoC.


Takashi

===

Takashi Iwai (6):
  ALSA: pcm: Add snd_mask_set_format() helper for standard usages
  ASoC: doc: Replace open code with params_set_format()
  ASoC: intel: Fix snd_pcm_format_t handling
  ASoC: fsl: Use snd_mask_set_format()
  ASoC: pcm186x: Declare PCM format with snd_pcm_format_t
  ASoC: dmaengine: Use standard pcm_format_to_bits() macro

 Documentation/sound/soc/dpcm.rst                    |  4 +---
 include/sound/pcm_params.h                          | 10 ++++++++--
 sound/soc/codecs/pcm186x.c                          |  2 +-
 sound/soc/fsl/fsl-asoc-card.c                       |  2 +-
 sound/soc/intel/boards/bdw-rt5677.c                 |  4 +---
 sound/soc/intel/boards/bxt_da7219_max98357a.c       |  2 +-
 sound/soc/intel/boards/bxt_rt298.c                  |  2 +-
 sound/soc/intel/boards/kbl_da7219_max98357a.c       |  2 +-
 sound/soc/intel/boards/kbl_rt5663_max98927.c        |  4 ++--
 sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c |  4 ++--
 sound/soc/intel/boards/skl_nau88l25_max98357a.c     |  2 +-
 sound/soc/intel/boards/skl_nau88l25_ssm4567.c       |  2 +-
 sound/soc/intel/boards/skl_rt286.c                  |  2 +-
 sound/soc/soc-generic-dmaengine-pcm.c               |  2 +-
 14 files changed, 23 insertions(+), 21 deletions(-)

Comments

Mark Brown July 26, 2018, 2:46 p.m. UTC | #1 
On Wed, Jul 25, 2018 at 11:17:16PM +0200, Takashi Iwai wrote:
> Hi,
> 
> the PCM format is a fixed type with __bitwise, and it needs cast or
> other trick to deal with integer.  This is a series of such fixes for
> ASoC.

Nice!  Should I just apply all these (including the initial patch adding
the helper)?
Takashi Iwai July 26, 2018, 3:03 p.m. UTC | #2 
On Thu, 26 Jul 2018 16:46:59 +0200,
Mark Brown wrote:
> 
> On Wed, Jul 25, 2018 at 11:17:16PM +0200, Takashi Iwai wrote:
> > Hi,
> > 
> > the PCM format is a fixed type with __bitwise, and it needs cast or
> > other trick to deal with integer.  This is a series of such fixes for
> > ASoC.
> 
> Nice!  Should I just apply all these (including the initial patch adding
> the helper)?

Yes, please.


Takashi