mbox series

[-,Multiple,plugins,0/4] Fix leaks on multiple plugins

Message ID 20180928212727.15151-1-andre.guedes@intel.com (mailing list archive)
Headers show
Series Fix leaks on multiple plugins | expand

Message

Guedes, Andre Sept. 28, 2018, 9:27 p.m. UTC 
Hi all,

While I was working on AAF plugin RFC v2 series [1], I spotted several leaks in
some plugins when handling *_hw_constraint() error cases. This series fixes
these issues.

Regards,

Andre

[1] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-September/140290.html

Andre Guedes (4):
  a52: Fix leaks when a52_set_hw_constraint() fails
  jack: Fix leaks when jack_set_hw_constraint() fails
  oss: Fix leaks when oss_hw_constraint() fails
  usb_stream: Fix leaks when us_set_hw_constraint() fails

 a52/pcm_a52.c               | 2 +-
 jack/pcm_jack.c             | 1 +
 oss/pcm_oss.c               | 2 +-
 usb_stream/pcm_usb_stream.c | 1 +
 4 files changed, 4 insertions(+), 2 deletions(-)

Comments

Takashi Sakamoto Oct. 2, 2018, 9:18 a.m. UTC | #1 
Hi,

On Sep 29 2018 06:27, Andre Guedes wrote:
> While I was working on AAF plugin RFC v2 series [1], I spotted several leaks in
> some plugins when handling *_hw_constraint() error cases. This series fixes
> these issues.
> 
> Regards,
> 
> Andre
> 
> [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-September/140290.html
> 
> Andre Guedes (4):
>    a52: Fix leaks when a52_set_hw_constraint() fails
>    jack: Fix leaks when jack_set_hw_constraint() fails
>    oss: Fix leaks when oss_hw_constraint() fails
>    usb_stream: Fix leaks when us_set_hw_constraint() fails
> 
>   a52/pcm_a52.c               | 2 +-
>   jack/pcm_jack.c             | 1 +
>   oss/pcm_oss.c               | 2 +-
>   usb_stream/pcm_usb_stream.c | 1 +
>   4 files changed, 4 insertions(+), 2 deletions(-)

I've reviewed all of the above patches.

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

I think it better for the plugins to use goto statement to
aggregate error paths for releasing allocated objects but this is
just for code cleanups.


Regards

Takashi Sakamoto
Takashi Iwai Oct. 2, 2018, 3:56 p.m. UTC | #2 
On Fri, 28 Sep 2018 23:27:23 +0200,
Andre Guedes wrote:
> 
> Hi all,
> 
> While I was working on AAF plugin RFC v2 series [1], I spotted several leaks in
> some plugins when handling *_hw_constraint() error cases. This series fixes
> these issues.
> 
> Regards,
> 
> Andre
> 
> [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-September/140290.html
> 
> Andre Guedes (4):
>   a52: Fix leaks when a52_set_hw_constraint() fails
>   jack: Fix leaks when jack_set_hw_constraint() fails
>   oss: Fix leaks when oss_hw_constraint() fails
>   usb_stream: Fix leaks when us_set_hw_constraint() fails

Applied all four patches now.  Thanks.


Takashi