mbox series

[0/3] ALSA: pcm: implement the anonymous dup

Message ID 20190129175909.17423-1-perex@perex.cz (mailing list archive)
Headers show
Series ALSA: pcm: implement the anonymous dup | expand

Message

Jaroslav Kysela Jan. 29, 2019, 5:59 p.m. UTC 
This patchset contains the anonymous dup implementation with permissions
checking for the ALSA's PCM interface in kernel to enable the restricted
DMA sound buffer sharing for the restricted tasks.

The code was tested through qemu and it seems to be pretty stable.

The initial tinyalsa implementation can be found here:

  https://github.com/perexg/tinyalsa/commits/anondup

The filtering might be refined. It depends on the real requirements.
Perhaps, we may create more ioctl groups. Any comments are more than
welcome.

Cc: Mark Brown <broonie@kernel.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Baolin Wang <baolin.wang@linaro.org>

Jaroslav Kysela (3):
  ALSA: pcm: implement the anonymous dup (inode file descriptor)
  ALSA: pcm: remove the file member from struct pcm
  ALSA: pcm: implement the ioctl/mmap filter for the anonymous dup

 include/sound/pcm.h         |  10 +--
 include/uapi/sound/asound.h |  12 +++-
 sound/core/oss/pcm_oss.c    |   3 +-
 sound/core/pcm.c            |  48 +++++++++-----
 sound/core/pcm_compat.c     |   1 +
 sound/core/pcm_native.c     | 154 +++++++++++++++++++++++++++++++++++++++++---
 6 files changed, 195 insertions(+), 33 deletions(-)

Comments

Mark Brown Jan. 29, 2019, 7:48 p.m. UTC | #1 
On Tue, Jan 29, 2019 at 06:59:06PM +0100, Jaroslav Kysela wrote:
> This patchset contains the anonymous dup implementation with permissions
> checking for the ALSA's PCM interface in kernel to enable the restricted
> DMA sound buffer sharing for the restricted tasks.

> The code was tested through qemu and it seems to be pretty stable.

> The initial tinyalsa implementation can be found here:

>   https://github.com/perexg/tinyalsa/commits/anondup

> The filtering might be refined. It depends on the real requirements.
> Perhaps, we may create more ioctl groups. Any comments are more than
> welcome.

Thanks for looking at this!  Copying in Phil who is probably best placed
to review these from an Android perspective.

> Cc: Mark Brown <broonie@kernel.org>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: Baolin Wang <baolin.wang@linaro.org>
> 
> Jaroslav Kysela (3):
>   ALSA: pcm: implement the anonymous dup (inode file descriptor)
>   ALSA: pcm: remove the file member from struct pcm
>   ALSA: pcm: implement the ioctl/mmap filter for the anonymous dup
> 
>  include/sound/pcm.h         |  10 +--
>  include/uapi/sound/asound.h |  12 +++-
>  sound/core/oss/pcm_oss.c    |   3 +-
>  sound/core/pcm.c            |  48 +++++++++-----
>  sound/core/pcm_compat.c     |   1 +
>  sound/core/pcm_native.c     | 154 +++++++++++++++++++++++++++++++++++++++++---
>  6 files changed, 195 insertions(+), 33 deletions(-)
> 
> -- 
> 2.13.6