mbox series

[v3,0/3] Add runtime PM for SAI digital audio interface

Message ID 20190422190213.30726-1-daniel.baluta@nxp.com (mailing list archive)
Headers show
Series Add runtime PM for SAI digital audio interface | expand

Message

Daniel Baluta April 22, 2019, 7:02 p.m. UTC 
First patch fixes a bug by correctly setting is_slave_mode, then
second patch adds support for runtime PM and finally 3rd patch moves
clock handling from startup/shtudown function to runtime PM handlers.

Changes since v2: (after Viorel's comments)
	- no need to check for is_slave_mode when enabling/disabling the clocks
	because sai->mclk_streams is only set when SAI is in master mode.

Changes since v1: (after Nicolin's comments)
	- added patch 1
	- added fsl_sai_remove in order to call pm_runtime_disable
	- only disable/enable mclk when SAI in master mode.

Daniel Baluta (2):
  ASoC: fsl_sai: Update is_slave_mode with correct value
  ASoC: fsl_sai: Add support for runtime pm

Shengjiu Wang (1):
  ASoC: fsl_sai: Move clock operation to PM runtime

 sound/soc/fsl/fsl_sai.c | 78 +++++++++++++++++++++++++++++++++--------
 1 file changed, 63 insertions(+), 15 deletions(-)

Comments

Viorel Suman April 23, 2019, 7:20 a.m. UTC | #1 
For this series:

Reviewed-by: Viorel Suman <viorel.suman@nxp.com>

On Lu, 2019-04-22 at 19:02 +0000, Daniel Baluta wrote:
> First patch fixes a bug by correctly setting is_slave_mode, then
> second patch adds support for runtime PM and finally 3rd patch moves
> clock handling from startup/shtudown function to runtime PM handlers.
> 
> Changes since v2: (after Viorel's comments)
> 	- no need to check for is_slave_mode when enabling/disabling the clocks
> 	because sai->mclk_streams is only set when SAI is in master mode.
> 
> Changes since v1: (after Nicolin's comments)
> 	- added patch 1
> 	- added fsl_sai_remove in order to call pm_runtime_disable
> 	- only disable/enable mclk when SAI in master mode.
> 
> Daniel Baluta (2):
>   ASoC: fsl_sai: Update is_slave_mode with correct value
>   ASoC: fsl_sai: Add support for runtime pm
> 
> Shengjiu Wang (1):
>   ASoC: fsl_sai: Move clock operation to PM runtime
> 
>  sound/soc/fsl/fsl_sai.c | 78 +++++++++++++++++++++++++++++++++--------
>  1 file changed, 63 insertions(+), 15 deletions(-)
> 
> -- 
> 2.17.1
>