| Message ID | 20190503220233.64546-1-gwendal@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Update cros_ec_commands.h | expand |
On Fri, 03 May 2019, Gwendal Grignou wrote: > The interface between CrosEC embedded controller and the host, > described by cros_ec_commands.h, as diverged from what the embedded > controller really support. > > The source of thruth is at > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h > > That include file is converted to remove ACPI and Embedded only code. > > From now on, cros_ec_commands.h will be automatically generated from > the file above, do not modify directly. > > Fell free to squash the commits below. > > Changes in v2: > - Move I2S changes at the end of the patchset, squashed with change in > sound/soc/codecs/cros_ec_codec.c to match new interface. > - Add Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > Gwendal Grignou (30): > mfd: cros_ec: Update license term > mfd: cros_ec: Zero BUILD_ macro > mfd: cros_ec: set comments properly > mfd: cros_ec: add ec_align macros > mfd: cros_ec: Define commands as 4-digit UPPER CASE hex values > mfd: cros_ec: use BIT macro > mfd: cros_ec: Update ACPI interface definition > mfd: cros_ec: move HDMI CEC API definition > mfd: cros_ec: Remove zero-size structs > mfd: cros_ec: Add Flash V2 commands API > mfd: cros_ec: Add PWM_SET_DUTY API > mfd: cros_ec: Add lightbar v2 API > mfd: cros_ec: Expand hash API > mfd: cros_ec: Add EC transport protocol v4 > mfd: cros_ec: Complete MEMS sensor API > mfd: cros_ec: Fix event processing API > mfd: cros_ec: Add fingerprint API > mfd: cros_ec: Fix temperature API > mfd: cros_ec: Complete Power and USB PD API > mfd: cros_ec: Add API for keyboard testing > mfd: cros_ec: Add Hibernate API > mfd: cros_ec: Add Smart Battery Firmware update API > mfd: cros_ec: Add I2C passthru protection API > mfd: cros_ec: Add API for EC-EC communication > mfd: cros_ec: Add API for Touchpad support > mfd: cros_ec: Add API for Fingerprint support > mfd: cros_ec: Add API for rwsig > mfd: cros_ec: Add SKU ID and Secure storage API > mfd: cros_ec: Add Management API entry points > mfd: cros_ec: Update I2S API > > include/linux/mfd/cros_ec_commands.h | 3735 +++++++++++++++++++++----- > sound/soc/codecs/cros_ec_codec.c | 8 +- > 2 files changed, 2997 insertions(+), 746 deletions(-) Again, it would be good to get 1 or 2 more Chromium Acks, given the extent of the changes.
Hi Gwendal, Hi Lee, On Tue, May 07, 2019 at 10:44:46AM +0100, Lee Jones wrote: > On Fri, 03 May 2019, Gwendal Grignou wrote: > > > The interface between CrosEC embedded controller and the host, > > described by cros_ec_commands.h, as diverged from what the embedded > > controller really support. > > > > The source of thruth is at > > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h > > > > That include file is converted to remove ACPI and Embedded only code. > > > > From now on, cros_ec_commands.h will be automatically generated from > > the file above, do not modify directly. > > > > Fell free to squash the commits below. > > > > Changes in v2: > > - Move I2S changes at the end of the patchset, squashed with change in > > sound/soc/codecs/cros_ec_codec.c to match new interface. > > - Add Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > > > Gwendal Grignou (30): > > mfd: cros_ec: Update license term > > mfd: cros_ec: Zero BUILD_ macro > > mfd: cros_ec: set comments properly > > mfd: cros_ec: add ec_align macros > > mfd: cros_ec: Define commands as 4-digit UPPER CASE hex values > > mfd: cros_ec: use BIT macro > > mfd: cros_ec: Update ACPI interface definition > > mfd: cros_ec: move HDMI CEC API definition > > mfd: cros_ec: Remove zero-size structs > > mfd: cros_ec: Add Flash V2 commands API > > mfd: cros_ec: Add PWM_SET_DUTY API > > mfd: cros_ec: Add lightbar v2 API > > mfd: cros_ec: Expand hash API > > mfd: cros_ec: Add EC transport protocol v4 > > mfd: cros_ec: Complete MEMS sensor API > > mfd: cros_ec: Fix event processing API > > mfd: cros_ec: Add fingerprint API > > mfd: cros_ec: Fix temperature API > > mfd: cros_ec: Complete Power and USB PD API > > mfd: cros_ec: Add API for keyboard testing > > mfd: cros_ec: Add Hibernate API > > mfd: cros_ec: Add Smart Battery Firmware update API > > mfd: cros_ec: Add I2C passthru protection API > > mfd: cros_ec: Add API for EC-EC communication > > mfd: cros_ec: Add API for Touchpad support > > mfd: cros_ec: Add API for Fingerprint support > > mfd: cros_ec: Add API for rwsig > > mfd: cros_ec: Add SKU ID and Secure storage API > > mfd: cros_ec: Add Management API entry points > > mfd: cros_ec: Update I2S API > > > > include/linux/mfd/cros_ec_commands.h | 3735 +++++++++++++++++++++----- > > sound/soc/codecs/cros_ec_codec.c | 8 +- > > 2 files changed, 2997 insertions(+), 746 deletions(-) > > Again, it would be good to get 1 or 2 more Chromium Acks, given the > extent of the changes. I've gone ahead and looked through all 30 of the changes here. It looks good to me. Acked-By: Benson Leung <bleung@chromium.org> Thanks Gwendal. Benson
On Wed, 08 May 2019, Benson Leung wrote: > Hi Gwendal, Hi Lee, > > On Tue, May 07, 2019 at 10:44:46AM +0100, Lee Jones wrote: > > On Fri, 03 May 2019, Gwendal Grignou wrote: > > > > > The interface between CrosEC embedded controller and the host, > > > described by cros_ec_commands.h, as diverged from what the embedded > > > controller really support. > > > > > > The source of thruth is at > > > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h > > > > > > That include file is converted to remove ACPI and Embedded only code. > > > > > > From now on, cros_ec_commands.h will be automatically generated from > > > the file above, do not modify directly. > > > > > > Fell free to squash the commits below. > > > > > > Changes in v2: > > > - Move I2S changes at the end of the patchset, squashed with change in > > > sound/soc/codecs/cros_ec_codec.c to match new interface. > > > - Add Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > > > > > Gwendal Grignou (30): > > > mfd: cros_ec: Update license term > > > mfd: cros_ec: Zero BUILD_ macro > > > mfd: cros_ec: set comments properly > > > mfd: cros_ec: add ec_align macros > > > mfd: cros_ec: Define commands as 4-digit UPPER CASE hex values > > > mfd: cros_ec: use BIT macro > > > mfd: cros_ec: Update ACPI interface definition > > > mfd: cros_ec: move HDMI CEC API definition > > > mfd: cros_ec: Remove zero-size structs > > > mfd: cros_ec: Add Flash V2 commands API > > > mfd: cros_ec: Add PWM_SET_DUTY API > > > mfd: cros_ec: Add lightbar v2 API > > > mfd: cros_ec: Expand hash API > > > mfd: cros_ec: Add EC transport protocol v4 > > > mfd: cros_ec: Complete MEMS sensor API > > > mfd: cros_ec: Fix event processing API > > > mfd: cros_ec: Add fingerprint API > > > mfd: cros_ec: Fix temperature API > > > mfd: cros_ec: Complete Power and USB PD API > > > mfd: cros_ec: Add API for keyboard testing > > > mfd: cros_ec: Add Hibernate API > > > mfd: cros_ec: Add Smart Battery Firmware update API > > > mfd: cros_ec: Add I2C passthru protection API > > > mfd: cros_ec: Add API for EC-EC communication > > > mfd: cros_ec: Add API for Touchpad support > > > mfd: cros_ec: Add API for Fingerprint support > > > mfd: cros_ec: Add API for rwsig > > > mfd: cros_ec: Add SKU ID and Secure storage API > > > mfd: cros_ec: Add Management API entry points > > > mfd: cros_ec: Update I2S API > > > > > > include/linux/mfd/cros_ec_commands.h | 3735 +++++++++++++++++++++----- > > > sound/soc/codecs/cros_ec_codec.c | 8 +- > > > 2 files changed, 2997 insertions(+), 746 deletions(-) > > > > Again, it would be good to get 1 or 2 more Chromium Acks, given the > > extent of the changes. > > I've gone ahead and looked through all 30 of the changes here. It looks good to me. > > Acked-By: Benson Leung <bleung@chromium.org> Thanks for taking he time.