mbox series

[0/5] ALSA: firewire-lib: unify tracing events for isoc packet

Message ID 20190519100109.14167-1-o-takashi@sakamocchi.jp (mailing list archive)
Headers show
Series ALSA: firewire-lib: unify tracing events for isoc packet | expand

Message

Takashi Sakamoto May 19, 2019, 10:01 a.m. UTC
Hi,

This patchset is for Linux kernel v5.3 development.

ALSA IEC 61883-1/6 packet streaming engine has four types of tracing
events to probe data of handled isochronous packets on IEEE 1394 bus.
The most parameters of data are common independent of type of
isochronous payload and inbound/outbound direction.

This commit unifies the tracing events as 'amdtp_packet'. Instead of
named tracing events, filtering functionality of Linux tracing
framework is available to filter out target events, like:

$ echo 'src == 0xffc0' > /sys/kernel/debug/tracing/events/snd_firewire_lib/amdtp_packet/filter
$ echo 1 > /sys/kernel/debug/tracing/events/snd_firewire_lib/amdtp_packet/enable
$ cat /sys/kernel/debug/tracing/trace
...
...: amdtp_packet: 00 0594 ffc0 ffc1 00 002 00 240 41 1 09 {0x0,0x2,0x0,0xf0,0x90,0x1,0xff,0xff}
...: amdtp_packet: 00 0595 ffc0 ffc1 00 018 08 240 42 1 10 {0x0,0x2,0x0,0xf0,0x90,0x1,0x4b,0x3d}

Takashi Sakamoto (5):
  firewire-lib: use the same type of argument for CIP header for tracing
    event
  firewire-lib: add data_blocks/data_block_counter parameter to
    in_packet/out_packet tracing events
  firewire-lib: use the same unit for payload argument in tracing events
  firewire-lib: use dynamic array for CIP header of tracing events
  firewire-lib: unify tracing events to 'amdtp_packet' event

 sound/firewire/amdtp-stream-trace.h | 163 ++++------------------------
 sound/firewire/amdtp-stream.c       |  16 +--
 2 files changed, 28 insertions(+), 151 deletions(-)

Comments

Takashi Iwai May 21, 2019, 5:48 a.m. UTC | #1
On Sun, 19 May 2019 12:01:04 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> This patchset is for Linux kernel v5.3 development.
> 
> ALSA IEC 61883-1/6 packet streaming engine has four types of tracing
> events to probe data of handled isochronous packets on IEEE 1394 bus.
> The most parameters of data are common independent of type of
> isochronous payload and inbound/outbound direction.
> 
> This commit unifies the tracing events as 'amdtp_packet'. Instead of
> named tracing events, filtering functionality of Linux tracing
> framework is available to filter out target events, like:
> 
> $ echo 'src == 0xffc0' > /sys/kernel/debug/tracing/events/snd_firewire_lib/amdtp_packet/filter
> $ echo 1 > /sys/kernel/debug/tracing/events/snd_firewire_lib/amdtp_packet/enable
> $ cat /sys/kernel/debug/tracing/trace
> ...
> ...: amdtp_packet: 00 0594 ffc0 ffc1 00 002 00 240 41 1 09 {0x0,0x2,0x0,0xf0,0x90,0x1,0xff,0xff}
> ...: amdtp_packet: 00 0595 ffc0 ffc1 00 018 08 240 42 1 10 {0x0,0x2,0x0,0xf0,0x90,0x1,0x4b,0x3d}
> 
> Takashi Sakamoto (5):
>   firewire-lib: use the same type of argument for CIP header for tracing
>     event
>   firewire-lib: add data_blocks/data_block_counter parameter to
>     in_packet/out_packet tracing events
>   firewire-lib: use the same unit for payload argument in tracing events
>   firewire-lib: use dynamic array for CIP header of tracing events
>   firewire-lib: unify tracing events to 'amdtp_packet' event

Applied all five patches now.  Thanks.


Takashi