mbox series

[00/19] ALSA: bebob/fireworks/oxfw: code refactoring toward rework for reservation of isochronous resources

Message ID 20190612084422.5344-1-o-takashi@sakamocchi.jp (mailing list archive)
Headers show
Series ALSA: bebob/fireworks/oxfw: code refactoring toward rework for reservation of isochronous resources | expand

Message

Takashi Sakamoto June 12, 2019, 8:44 a.m. UTC
Hi,

This patchset is a part of patches to reserve/release isochronous
resources in pcm.hw_params/hw_free callbacks, like posted patchsets
below:
https://mailman.alsa-project.org/pipermail/alsa-devel/2019-June/150118.html
https://mailman.alsa-project.org/pipermail/alsa-devel/2019-June/150863.html

However, in this patchset, I focus on code refactoring, due to kernel
API implementation in firewire-lib.

The target devices supported by ALSA bebob, fireworks and oxfw drivers
implements Connection Management Procedure (CMP) in IEC 61883-1. For
CMP, the drivers use kernel API in firewire-lib. This API has private
data including the data for isochronous resources, and its
implementation is tightly-coupled to maintenance of isochronous
resources.

This patchset is a preparation for future work to change the CMP
implementation.

Takashi Sakamoto (19):
  ALSA: bebob: configure sampling transfer frequency in pcm.hw_params
    callback
  ALSA: bebob: don't set XRUN in stop streaming
  ALSA: bebob: obsolete useless member of private structure
  ALSA: bebob: code refactoring to initialize/destroy stream data
  ALSA: fireworks: unify substream counter
  ALSA: fireworks: code refactoring for rawmidi.open/close
  ALSA: fireworks: code refactoring for pcm.hw_params/hw_free
  ALSA: fireworks: configure sampling transfer frequency in
    pcm.hw_params callback
  ALSA: fireworks: configure stream parameters in pcm.hw_params callback
  ALSA: fireworks: don't set XRUN in stop streaming
  ALSA: oxfw: code refactoring for stop condition of packet streaming
  ALSA: oxfw: set packet parameter according to current configuration
  ALSA: oxfw: start duplex streams if supported
  ALSA: oxfw: break packet streaming at bus-reset handler
  ALSA: oxfw: expand stop procedure for packet streaming
  ALSA: oxfw: rename helper functions for duplex streams
  ALSA: oxfw: unify substreams counter
  ALSA: oxfw: configure packet format in pcm.hw_params callback
  ALSA: oxfw: configure stream parameter in pcm.hw_params callback

 sound/firewire/bebob/bebob.h                |   5 +-
 sound/firewire/bebob/bebob_midi.c           |  22 +-
 sound/firewire/bebob/bebob_pcm.c            |  22 +-
 sound/firewire/bebob/bebob_stream.c         | 339 ++++++++++----------
 sound/firewire/fireworks/fireworks.h        |   6 +-
 sound/firewire/fireworks/fireworks_midi.c   |  54 +---
 sound/firewire/fireworks/fireworks_pcm.c    |  59 +---
 sound/firewire/fireworks/fireworks_stream.c | 159 +++++----
 sound/firewire/oxfw/oxfw-midi.c             |  22 +-
 sound/firewire/oxfw/oxfw-pcm.c              |  34 +-
 sound/firewire/oxfw/oxfw-stream.c           | 335 ++++++++++---------
 sound/firewire/oxfw/oxfw.c                  |  17 +-
 sound/firewire/oxfw/oxfw.h                  |  22 +-
 13 files changed, 553 insertions(+), 543 deletions(-)

Comments

Takashi Iwai June 12, 2019, 1:30 p.m. UTC | #1
On Wed, 12 Jun 2019 10:44:03 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> This patchset is a part of patches to reserve/release isochronous
> resources in pcm.hw_params/hw_free callbacks, like posted patchsets
> below:
> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-June/150118.html
> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-June/150863.html
> 
> However, in this patchset, I focus on code refactoring, due to kernel
> API implementation in firewire-lib.
> 
> The target devices supported by ALSA bebob, fireworks and oxfw drivers
> implements Connection Management Procedure (CMP) in IEC 61883-1. For
> CMP, the drivers use kernel API in firewire-lib. This API has private
> data including the data for isochronous resources, and its
> implementation is tightly-coupled to maintenance of isochronous
> resources.
> 
> This patchset is a preparation for future work to change the CMP
> implementation.
> 
> Takashi Sakamoto (19):
>   ALSA: bebob: configure sampling transfer frequency in pcm.hw_params
>     callback
>   ALSA: bebob: don't set XRUN in stop streaming
>   ALSA: bebob: obsolete useless member of private structure
>   ALSA: bebob: code refactoring to initialize/destroy stream data
>   ALSA: fireworks: unify substream counter
>   ALSA: fireworks: code refactoring for rawmidi.open/close
>   ALSA: fireworks: code refactoring for pcm.hw_params/hw_free
>   ALSA: fireworks: configure sampling transfer frequency in
>     pcm.hw_params callback
>   ALSA: fireworks: configure stream parameters in pcm.hw_params callback
>   ALSA: fireworks: don't set XRUN in stop streaming
>   ALSA: oxfw: code refactoring for stop condition of packet streaming
>   ALSA: oxfw: set packet parameter according to current configuration
>   ALSA: oxfw: start duplex streams if supported
>   ALSA: oxfw: break packet streaming at bus-reset handler
>   ALSA: oxfw: expand stop procedure for packet streaming
>   ALSA: oxfw: rename helper functions for duplex streams
>   ALSA: oxfw: unify substreams counter
>   ALSA: oxfw: configure packet format in pcm.hw_params callback
>   ALSA: oxfw: configure stream parameter in pcm.hw_params callback

Applied all 19 patches now.  Thanks.


Takashi