[v2,0/2] ALSA: usb-audio: fix PCM device order

Message

Takashi Iwai July 27, 2019, 9:30 a.m. UTC

Hi,

this is a rewrite of the old USB-audio fix patch I obviously
overlooked to adapt to 5.3 kernel with a preliminary cleanup patch.

Totally untested, so any test / feedback would be appreciated.


thanks,

Takashi

===

Alexander Tsoy (1):
  ALSA: usb-audio: fix PCM device order

Takashi Iwai (1):
  ALSA: usb-audio: Unify audioformat release code

 sound/usb/stream.c | 64 +++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 47 insertions(+), 17 deletions(-)

Comments

Tanu Kaskinen July 28, 2019, 9:56 a.m. UTC | #1

On Sat, 2019-07-27 at 11:30 +0200, Takashi Iwai wrote:
> Hi,
> 
> this is a rewrite of the old USB-audio fix patch I obviously
> overlooked to adapt to 5.3 kernel with a preliminary cleanup patch.
> 
> Totally untested, so any test / feedback would be appreciated.

Thanks for the patches! Unfortunately I can't test them, and the
reporter who prompted me to ping apparently isn't going to test them
either. Hopefully the patches are still relevant to Alexander so maybe
he could test them.

Alexander Tsoy Dec. 30, 2019, 6:01 p.m. UTC | #2

В Вс, 28/07/2019 в 12:56 +0300, Tanu Kaskinen пишет:
> On Sat, 2019-07-27 at 11:30 +0200, Takashi Iwai wrote:
> > Hi,
> > 
> > this is a rewrite of the old USB-audio fix patch I obviously
> > overlooked to adapt to 5.3 kernel with a preliminary cleanup patch.
> > 
> > Totally untested, so any test / feedback would be appreciated.
> 
> Thanks for the patches! Unfortunately I can't test them, and the
> reporter who prompted me to ping apparently isn't going to test them
> either. Hopefully the patches are still relevant to Alexander so
> maybe
> he could test them.

Sorry for the late reply, I messed up my mail filters. HUD-mx2 now
works as expected without workarounds in alsa or pulse. Tested with
5.4.x. Thanks!

Takashi Iwai Dec. 30, 2019, 9:27 p.m. UTC | #3

On Mon, 30 Dec 2019 19:01:43 +0100,
Alexander Tsoy wrote:
> 
> В Вс, 28/07/2019 в 12:56 +0300, Tanu Kaskinen пишет:
> > On Sat, 2019-07-27 at 11:30 +0200, Takashi Iwai wrote:
> > > Hi,
> > > 
> > > this is a rewrite of the old USB-audio fix patch I obviously
> > > overlooked to adapt to 5.3 kernel with a preliminary cleanup patch.
> > > 
> > > Totally untested, so any test / feedback would be appreciated.
> > 
> > Thanks for the patches! Unfortunately I can't test them, and the
> > reporter who prompted me to ping apparently isn't going to test them
> > either. Hopefully the patches are still relevant to Alexander so
> > maybe
> > he could test them.
> 
> Sorry for the late reply, I messed up my mail filters. HUD-mx2 now
> works as expected without workarounds in alsa or pulse. Tested with
> 5.4.x. Thanks!

Good to hear.

So far there is no real regression report, so it seems working for
other devices, too.


thanks,

Takashi