[v2,0/5] soundwire: intel: add DAI callbacks

Message

Pierre-Louis Bossart Jan. 14, 2020, 11:42 p.m. UTC

The existing mainline code is missing most of the DAI callbacks needed
for a functional implementation, and the existing ones need to be
modified to provide the relevant information to SOF drivers.

As suggested by Vinod, these patches are shared first - with the risk
that they are separated from the actual DAI enablement, so reviewers
might wonder why they are needed in the first place.

For reference, the complete set of 90+ patches required for SoundWire
on Intel platforms is available here:

https://github.com/thesofproject/linux/pull/1692

changes since v1:
Fix string allocation (only feedback from Vinod)

Pierre-Louis Bossart (2):
  soundwire: intel: rename res field as link_res
  soundwire: intel: free all resources on hw_free()

Rander Wang (3):
  soundwire: intel: add prepare support in sdw dai driver
  soundwire: intel: add trigger support in sdw dai driver
  soundwire: intel: add sdw_stream_setup helper for .startup callback

 drivers/soundwire/intel.c | 197 ++++++++++++++++++++++++++++++++++----
 1 file changed, 177 insertions(+), 20 deletions(-)

Comments

Pierre-Louis Bossart Feb. 10, 2020, 2:28 p.m. UTC | #1

On 1/14/20 5:42 PM, Pierre-Louis Bossart wrote:
> The existing mainline code is missing most of the DAI callbacks needed
> for a functional implementation, and the existing ones need to be
> modified to provide the relevant information to SOF drivers.
> 
> As suggested by Vinod, these patches are shared first - with the risk
> that they are separated from the actual DAI enablement, so reviewers
> might wonder why they are needed in the first place.
> 
> For reference, the complete set of 90+ patches required for SoundWire
> on Intel platforms is available here:
> 
> https://github.com/thesofproject/linux/pull/1692

Vinod, these patches have been in the queue for quite some time, and 
v5.6-rc1 is out. Can we move on with the reviews?
Thanks!

> 
> changes since v1:
> Fix string allocation (only feedback from Vinod)
> 
> Pierre-Louis Bossart (2):
>    soundwire: intel: rename res field as link_res
>    soundwire: intel: free all resources on hw_free()
> 
> Rander Wang (3):
>    soundwire: intel: add prepare support in sdw dai driver
>    soundwire: intel: add trigger support in sdw dai driver
>    soundwire: intel: add sdw_stream_setup helper for .startup callback
> 
>   drivers/soundwire/intel.c | 197 ++++++++++++++++++++++++++++++++++----
>   1 file changed, 177 insertions(+), 20 deletions(-)
>