From patchwork Fri Feb 14 11:13:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 11382107 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 41670109A for ; Fri, 14 Feb 2020 11:14:10 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6D852082F for ; Fri, 14 Feb 2020 11:14:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="fQzf0e+Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6D852082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 906F5165D; Fri, 14 Feb 2020 12:13:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 906F5165D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581678847; bh=e0JqCyb+OdKceQ9QjeGC+L7kSvxK2wiprm2t0AnFR4U=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=fQzf0e+YFWd9H+Dan5xFm8yauBuh1NgKeYnFL/47vEpE9esd7z+80kbGGkl7xa1F5 YnpW7OWFxJAh61fx7F17tSLIKsUHvwH/ISLHJJylhPZDDxa8PDeH5G5PC8ZnkaAv/p 1HturyLPud3FjlYKG8JZet6xFK0E0vZXs0jTHI3Q= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E711EF80157; Fri, 14 Feb 2020 12:13:23 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 221EAF80158; Fri, 14 Feb 2020 12:13:22 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=3.4.0 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6B131F80086 for ; Fri, 14 Feb 2020 12:13:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6B131F80086 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4223AB1CA for ; Fri, 14 Feb 2020 11:13:18 +0000 (UTC) From: Takashi Iwai To: alsa-devel@alsa-project.org Date: Fri, 14 Feb 2020 12:13:13 +0100 Message-Id: <20200214111316.26939-1-tiwai@suse.de> X-Mailer: git-send-email 2.16.4 Subject: [alsa-devel] [PATCH 0/3] ALSA: KCSAN fixes X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, recently syzbot reports repeatedly about the concurrent accesses with KCSAN. Those should be mostly harmless but still safer to be papered over, so here are fixes. There are two fixes for ALSA sequencer core, one about applying the spinlock for the queue bitmap flag accesses, and another about the current time retrievals. The last patch is about rawmidi and changes simply bit fields to bools. I didn't mark them Cc-to-stable because there are no reproducer and the patterns are basically safe -- although it's fine to backport these patches to stable branches. Takashi === Takashi Iwai (3): ALSA: seq: Avoid concurrent access to queue flags ALSA: seq: Fix concurrent access to queue current tick/time ALSA: rawmidi: Avoid bit fields for state flags include/sound/rawmidi.h | 6 +++--- sound/core/seq/seq_clientmgr.c | 4 ++-- sound/core/seq/seq_queue.c | 29 ++++++++++++++++++++++------- sound/core/seq/seq_timer.c | 13 ++++++++++--- sound/core/seq/seq_timer.h | 3 ++- 5 files changed, 39 insertions(+), 16 deletions(-)