mbox series

[0/3] ASoC: Intel: boards: Revert SSP0 links to use dummy

Message ID 20200325131611.545-1-cezary.rojewski@intel.com (mailing list archive)
Headers show
Series ASoC: Intel: boards: Revert SSP0 links to use dummy | expand

Message

Cezary Rojewski March 25, 2020, 1:16 p.m. UTC 
Recent series of patches targeting broadwell boards, while enabling
SOF, changed behavior for non-SOF solutions. In essence replacing
platform 'dummy' with actual 'platform' causes redundant stream
initialization to occur during audio start. hw_params for haswell-pcm
destroys initial stream right after its creation - only to recreate it
again from proceed from there.

While harmless so far, this flow isn't right and should be corrected.
The actual need for dummy components for SSP0 link is questionable but
that issue is subject for another series.

Link to first message in conversation:
https://lkml.org/lkml/2020/3/18/54

Cezary Rojewski (3):
  ASoC: Intel: broadwell: Revert back SSP0 link to use dummy components
  ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy components
  ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy components

 sound/soc/intel/boards/bdw-rt5650.c | 7 ++++---
 sound/soc/intel/boards/bdw-rt5677.c | 7 ++++---
 sound/soc/intel/boards/broadwell.c  | 7 ++++---
 3 files changed, 12 insertions(+), 9 deletions(-)

Comments

Pierre-Louis Bossart March 25, 2020, 2:37 p.m. UTC | #1 
On 3/25/20 8:16 AM, Cezary Rojewski wrote:
> Recent series of patches targeting broadwell boards, while enabling
> SOF, changed behavior for non-SOF solutions. In essence replacing
> platform 'dummy' with actual 'platform' causes redundant stream
> initialization to occur during audio start. hw_params for haswell-pcm
> destroys initial stream right after its creation - only to recreate it
> again from proceed from there.
> 
> While harmless so far, this flow isn't right and should be corrected.
> The actual need for dummy components for SSP0 link is questionable but
> that issue is subject for another series.
> 
> Link to first message in conversation:
> https://lkml.org/lkml/2020/3/18/54
> 
> Cezary Rojewski (3):
>    ASoC: Intel: broadwell: Revert back SSP0 link to use dummy components
>    ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy components
>    ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy components

Thanks Cezary, for the series

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> 
>   sound/soc/intel/boards/bdw-rt5650.c | 7 ++++---
>   sound/soc/intel/boards/bdw-rt5677.c | 7 ++++---
>   sound/soc/intel/boards/broadwell.c  | 7 ++++---
>   3 files changed, 12 insertions(+), 9 deletions(-)
>