[00/13] ALSA: hda: Use LED classdev for mute controls consistently

Message

Takashi Iwai June 18, 2020, 11:08 a.m. UTC

Hi,

this is a patch set inspired by the recent patch Kai-Heng posted about
the HD-audio mic-mute LED control.  Currently HD-audio driver deals
with the mute and mic-mute LED in several different ways: primarily
with the direct callback of vmaster hook and capture sync hook, while
another with the LED class device binding.  The latter has been used
for binding with the platform device LEDs like Thinkpad, Dell,
Huawei.  And, yet, recently we added our own LED classdev for the
mic-mute LED on some HP systems although they are controlled directly
with the callback; it's exposed, however, for the DMIC that is
governed by a different ASoC driver.

This patch set is an attempt to sort out and make them consistent:
namely, 
* All LEDs are now controlled via LED class device
* The generic driver provides helper functions to easily build up the
  LED class dev and the relevant mixer controls
* Conversion of the existing framework and clean ups

The patches are lightly tested in my side with a couple of machines
and also through hda-emu tests.  Some devices receive new kcontrols
for the mute LED behavior (that have been missing so far), but
anything else look good though my tests.


thanks,

Takashi

===

Takashi Iwai (13):
  ALSA: hda: generic: Always call led-trigger for mic mute LED
  ALSA: hda: generic: Add a helper for mic-mute LED with LED classdev
  ALSA: hda/realtek: Convert to cdev-variant of mic-mute LED controls
  ALSA: hda/conexant: Convert to cdev-variant of mic-mute LED controls
  ALSA: hda/sigmatel: Convert to cdev-variant of mic-mute LED controls
  ALSA: hda: generic: Drop unused snd_hda_gen_fixup_micmute_led()
  ALSA: hda: generic: Drop the old mic-mute LED hook
  ALSA: hda: generic: Add vmaster mute LED helper
  ALSA: hda/realtek: Use the new vmaster mute LED helper
  ALSA: hda/conexant: Use the new vmaster mute LED helper
  ALSA: hda/sigmatel: Use the new vmaster mute LED helper
  ALSA: hda/realtek: Unify LED helper code
  ALSA: hda: Let LED cdev handling suspend/resume

 sound/pci/hda/Kconfig           |   9 ++
 sound/pci/hda/hda_generic.c     | 134 ++++++++++++++++--------
 sound/pci/hda/hda_generic.h     |  13 ++-
 sound/pci/hda/patch_conexant.c  |  47 ++++-----
 sound/pci/hda/patch_realtek.c   | 220 +++++++++++++++++++---------------------
 sound/pci/hda/patch_sigmatel.c  |  22 ++--
 sound/pci/hda/thinkpad_helper.c |  19 +---
 7 files changed, 248 insertions(+), 216 deletions(-)