mbox series

[alsa-lib,v2,0/2] Make dmix lockless operation optional

Message ID 20200623154931.27755-1-tiwai@suse.de (mailing list archive)
Headers show
Series Make dmix lockless operation optional | expand

Message

Takashi Iwai June 23, 2020, 3:49 p.m. UTC 
Hi,

this is a revised patch set for the PCM dmix, to make the lockless
operation optional and fix the semaphore usage in the lockless mode.

Unfortunately I got a server problem in the last week and lost many
posts during the weekend, so I couldn't follow up to the thread (I
just read from the lore archive).

In this patch set, to make my intention clearer, I swapped the
patches: the first to disable the lockless operation as default and
the second to fix the semaphore usage in the lockless mode.

In the first patch, the magic number is changed as Jaroslav suggested,
and the description has been updated.  The second patch is equivalent
with the previous one.


thanks,

Takashi

===

Takashi Iwai (2):
  pcm: dmix: make lockless operation optional
  pcm: dmix: Fix semaphore usage with lockless operation

 configure.ac               | 13 +++++++++++++
 src/pcm/pcm_direct.c       | 16 +++++++++++++---
 src/pcm/pcm_direct.h       |  1 +
 src/pcm/pcm_dmix.c         | 18 +++++++++++-------
 src/pcm/pcm_dmix_generic.c |  2 +-
 src/pcm/pcm_dmix_i386.c    |  1 +
 src/pcm/pcm_dmix_x86_64.c  |  1 +
 7 files changed, 41 insertions(+), 11 deletions(-)

Comments

Jaroslav Kysela July 1, 2020, 2:59 p.m. UTC | #1 
Dne 23. 06. 20 v 17:49 Takashi Iwai napsal(a):
> Hi,
> 
> this is a revised patch set for the PCM dmix, to make the lockless
> operation optional and fix the semaphore usage in the lockless mode.
> 
> Unfortunately I got a server problem in the last week and lost many
> posts during the weekend, so I couldn't follow up to the thread (I
> just read from the lore archive).
> 
> In this patch set, to make my intention clearer, I swapped the
> patches: the first to disable the lockless operation as default and
> the second to fix the semaphore usage in the lockless mode.
> 
> In the first patch, the magic number is changed as Jaroslav suggested,
> and the description has been updated.  The second patch is equivalent
> with the previous one.

All looks good now, thanks:

Reviewed-by: Jaroslav Kysela <perex@perex.cz>

				Jaroslav

> 
> 
> thanks,
> 
> Takashi
> 
> ===
> 
> Takashi Iwai (2):
>    pcm: dmix: make lockless operation optional
>    pcm: dmix: Fix semaphore usage with lockless operation
> 
>   configure.ac               | 13 +++++++++++++
>   src/pcm/pcm_direct.c       | 16 +++++++++++++---
>   src/pcm/pcm_direct.h       |  1 +
>   src/pcm/pcm_dmix.c         | 18 +++++++++++-------
>   src/pcm/pcm_dmix_generic.c |  2 +-
>   src/pcm/pcm_dmix_i386.c    |  1 +
>   src/pcm/pcm_dmix_x86_64.c  |  1 +
>   7 files changed, 41 insertions(+), 11 deletions(-)
>
Takashi Iwai July 7, 2020, 9:58 a.m. UTC | #2 
On Wed, 01 Jul 2020 16:59:49 +0200,
Jaroslav Kysela wrote:
> 
> Dne 23. 06. 20 v 17:49 Takashi Iwai napsal(a):
> > Hi,
> >
> > this is a revised patch set for the PCM dmix, to make the lockless
> > operation optional and fix the semaphore usage in the lockless mode.
> >
> > Unfortunately I got a server problem in the last week and lost many
> > posts during the weekend, so I couldn't follow up to the thread (I
> > just read from the lore archive).
> >
> > In this patch set, to make my intention clearer, I swapped the
> > patches: the first to disable the lockless operation as default and
> > the second to fix the semaphore usage in the lockless mode.
> >
> > In the first patch, the magic number is changed as Jaroslav suggested,
> > and the description has been updated.  The second patch is equivalent
> > with the previous one.
> 
> All looks good now, thanks:
> 
> Reviewed-by: Jaroslav Kysela <perex@perex.cz>

Thanks, now pushed out.


Takashi