[v2,0/3] ASoC: rt1015: fix compilation errors and warnings

Message

Tzung-Bi Shih June 25, 2020, 3:35 p.m. UTC

The series fixes compilation errors and warnings discovered in the thread
https://patchwork.kernel.org/patch/11622319/.

The original patch:
(1) adds acpi.h for fixing implicit declaration of function 'ACPI_PTR'
(2) sorts header inclusions in alphabetical

The compilation errors and warnings are likely introduced by (2).

The 1st and 2nd patches fix the newly discovered errors and warnings.
The 3rd patch is the same as the original patch.

Tzung-Bi Shih (3):
  ASoC: core: move definition of enum snd_soc_bias_level
  ASoC: dapm: declare missing structure prototypes
  ASoC: rt1015: add missing header inclusion

 include/sound/soc-dapm.h  | 20 ++++++++++++++++++++
 include/sound/soc.h       | 18 ------------------
 sound/soc/codecs/rt1015.c | 17 +++++++++--------
 3 files changed, 29 insertions(+), 26 deletions(-)

Comments

Mark Brown June 25, 2020, 7:12 p.m. UTC | #1

On Thu, 25 Jun 2020 23:35:40 +0800, Tzung-Bi Shih wrote:
> The series fixes compilation errors and warnings discovered in the thread
> https://patchwork.kernel.org/patch/11622319/.
> 
> The original patch:
> (1) adds acpi.h for fixing implicit declaration of function 'ACPI_PTR'
> (2) sorts header inclusions in alphabetical
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: core: move definition of enum snd_soc_bias_level
      commit: 10e834099d38dd2c02bf2bd5feaa3997cfcf139f
[2/3] ASoC: dapm: declare missing structure prototypes
      commit: 3d62ef4280a377bb2ccaee4e8f6c5093f5b8f9d4
[3/3] ASoC: rt1015: add missing header inclusion
      commit: 72ac4a4bef48e67bb26bc5a01d68c8163def013d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Tzung-Bi Shih June 29, 2020, 5:48 a.m. UTC | #2

On Fri, Jun 26, 2020 at 3:12 AM Mark Brown <[e-mail]> wrote:
>
> On Thu, 25 Jun 2020 23:35:40 +0800, Tzung-Bi Shih wrote:
> > The series fixes compilation errors and warnings discovered in the thread
> > https://patchwork.kernel.org/patch/11622319/.
> >
> > The original patch:
> > (1) adds acpi.h for fixing implicit declaration of function 'ACPI_PTR'
> > (2) sorts header inclusions in alphabetical

I am wondering if it is a better practice (next time) to separate the
original patch into 2 patches.

Mark Brown June 29, 2020, 11:38 a.m. UTC | #3

On Mon, Jun 29, 2020 at 01:48:41PM +0800, Tzung-Bi Shih wrote:
> On Fri, Jun 26, 2020 at 3:12 AM Mark Brown <[e-mail]> wrote:

> > > The original patch:
> > > (1) adds acpi.h for fixing implicit declaration of function 'ACPI_PTR'
> > > (2) sorts header inclusions in alphabetical

> I am wondering if it is a better practice (next time) to separate the
> original patch into 2 patches.

Yes.