[RFC,00/23] ALSA: fix kernel-doc and W=1 warnings

Message

Pierre-Louis Bossart July 2, 2020, 7:35 p.m. UTC

This cleanup touches a lot of old - and very old code for hardware
designed in the late 1990s/early 2000s -, hence the RFC status. I
mostly did dumb edits just to make warnings go away, suggestions and
feedback welcome.

Pierre-Louis Bossart (23):
  ALSA: isa/gus: remove -Wmissing-prototypes warnings
  ALSA: isa/gus: remove 'set but not used' warning
  ALSA: pci/asihpi: remove 'set but not used' warnings
  ALSA: pci/asihpi: fix kernel-doc
  ALSA: pci/asihpi: remove 'set but not used' warning
  ALSA: pci/echoaudio: remove 'set but not used' warning
  ALSA: pci/aw2-saa7146: remove 'set but not used' warning
  ALSA: pci/ctxfi/ctatc: fix kernel-doc
  ALSA: pci/ctxfi: fix kernel-doc warnings
  ALSA: usb/line6: remove 'defined but not used' warning
  ASoC: pci/emu10k1: remove "set but not used' warnings
  ALSA: firewire: fix kernel-doc
  ALSA: pci/emu10k1: remove 'set but not used' warning
  ALSA: pci/korg1212: remove 'set but not used' warnings
  ALSA: pci/rme9652/hdspm: remove always true condition
  ALSA: pci/oxygen/xonar_wm87x6: remove always true condition
  ALSA: xen: remove 'set but not used' warning
  ALSA: pci/es1938: remove 'set but not used' warning
  ALSA: pci/fm801: fix kernel-doc
  ALSA: pci/via82xx: remove 'set but not used' warnings
  ALSA: pcmcia/pdaudiocf: fix kernel-doc
  ALSA: vx_core: remove warning for empty loop body
  ALSA: pci/au88x0: remove "defined but not used" warnings

 include/sound/gus.h                |  4 ++++
 sound/drivers/vx/vx_core.c         |  3 ++-
 sound/firewire/cmp.c               |  1 -
 sound/isa/gus/gus_reset.c          |  2 --
 sound/isa/gus/gus_uart.c           |  3 ++-
 sound/pci/asihpi/asihpi.c          | 12 +++++-----
 sound/pci/asihpi/hpicmn.c          | 26 +++++++++++----------
 sound/pci/au88x0/au88x0_a3ddata.c  |  8 +++----
 sound/pci/au88x0/au88x0_xtalk.c    | 36 +++++++++++++++---------------
 sound/pci/aw2/aw2-saa7146.c        |  2 +-
 sound/pci/ctxfi/ctatc.c            |  4 ++++
 sound/pci/ctxfi/cthardware.c       |  2 +-
 sound/pci/ctxfi/cthw20k1.c         |  2 +-
 sound/pci/ctxfi/cthw20k2.c         |  2 +-
 sound/pci/ctxfi/ctimap.c           |  2 +-
 sound/pci/ctxfi/ctmixer.c          |  2 +-
 sound/pci/ctxfi/ctpcm.c            |  2 +-
 sound/pci/echoaudio/echoaudio.c    |  3 ++-
 sound/pci/emu10k1/emu10k1_main.c   |  4 ++--
 sound/pci/emu10k1/emu10k1_patch.c  |  3 ++-
 sound/pci/es1938.c                 |  3 ++-
 sound/pci/fm801.c                  | 27 ++++++++++++++++++++++
 sound/pci/korg1212/korg1212.c      |  4 +++-
 sound/pci/oxygen/xonar_wm87x6.c    |  6 +++--
 sound/pci/rme9652/hdspm.c          |  4 ++--
 sound/pci/via82xx.c                |  2 +-
 sound/pci/via82xx_modem.c          |  2 +-
 sound/pcmcia/pdaudiocf/pdaudiocf.c |  1 +
 sound/usb/line6/driver.h           |  4 ++--
 sound/xen/xen_snd_front.c          |  2 +-
 30 files changed, 110 insertions(+), 68 deletions(-)

Comments

Takashi Iwai July 7, 2020, 10:21 a.m. UTC | #1

On Thu, 02 Jul 2020 21:35:41 +0200,
Pierre-Louis Bossart wrote:
> 
> This cleanup touches a lot of old - and very old code for hardware
> designed in the late 1990s/early 2000s -, hence the RFC status. I
> mostly did dumb edits just to make warnings go away, suggestions and
> feedback welcome.
> 
> Pierre-Louis Bossart (23):
>   ALSA: isa/gus: remove -Wmissing-prototypes warnings
>   ALSA: isa/gus: remove 'set but not used' warning
>   ALSA: pci/asihpi: remove 'set but not used' warnings
>   ALSA: pci/asihpi: fix kernel-doc
>   ALSA: pci/asihpi: remove 'set but not used' warning
>   ALSA: pci/echoaudio: remove 'set but not used' warning
>   ALSA: pci/aw2-saa7146: remove 'set but not used' warning
>   ALSA: pci/ctxfi/ctatc: fix kernel-doc
>   ALSA: pci/ctxfi: fix kernel-doc warnings
>   ALSA: usb/line6: remove 'defined but not used' warning
>   ASoC: pci/emu10k1: remove "set but not used' warnings
>   ALSA: firewire: fix kernel-doc
>   ALSA: pci/emu10k1: remove 'set but not used' warning
>   ALSA: pci/korg1212: remove 'set but not used' warnings
>   ALSA: pci/rme9652/hdspm: remove always true condition
>   ALSA: pci/oxygen/xonar_wm87x6: remove always true condition
>   ALSA: xen: remove 'set but not used' warning
>   ALSA: pci/es1938: remove 'set but not used' warning
>   ALSA: pci/fm801: fix kernel-doc
>   ALSA: pci/via82xx: remove 'set but not used' warnings
>   ALSA: pcmcia/pdaudiocf: fix kernel-doc
>   ALSA: vx_core: remove warning for empty loop body
>   ALSA: pci/au88x0: remove "defined but not used" warnings

Those look OK although __maybe_unused and __always_unused aren't
always intuitive.  At least better than spewing the warnings
unnecessarily.

The line6 patch hasn't been applied yet because it might be clearer to
be replaced with define instead.  A similar argument may be applied to
au88x0 code, but this is much uglier and I'd take a more
straightforward fix by your patch.

So, now all but patch#10 are applied to for-next branch.


Thanks!

Takashi