| Message ID | 20200828072101.3781956-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | soundwire: use FIELD_{GET|PREP} in subsystem | expand |
On 8/28/2020 3:20 PM, Vinod Koul wrote: > Use the FIELD_{GET|PREP} in soundwire subsytem and remove the local > SDW_REG_SHIFT(). This makes code IMO look much neater > > Tested this on db845c board > > Bard, can you please verify this on intel boards. Somehow it doesn't work on intel boards. I am still looking into it. > > Vinod Koul (9): > soundwire: define and use addr bit masks > soundwire: bus: use FIELD_GET() > soundwire: slave: use SDW_DISCO_LINK_ID() > soundwire: stream: use FIELD_{GET|PREP} > soundwire: qcom : use FIELD_{GET|PREP} > soundwire: cadence: use FIELD_{GET|PREP} > soundwire: intel: use FIELD_{GET|PREP} > soundwire: intel_init: use FIELD_{GET|PREP} > soundwire: remove SDW_REG_SHIFT() > > drivers/soundwire/bus.c | 6 +-- > drivers/soundwire/cadence_master.c | 53 ++++++++++--------------- > drivers/soundwire/intel.c | 40 +++++++------------ > drivers/soundwire/intel_init.c | 2 +- > drivers/soundwire/qcom.c | 22 ++++------ > drivers/soundwire/slave.c | 2 +- > drivers/soundwire/stream.c | 13 +++--- > include/linux/soundwire/sdw.h | 21 ++++++---- > include/linux/soundwire/sdw_registers.h | 7 ---- > 9 files changed, 67 insertions(+), 99 deletions(-) >
Use the FIELD_{GET|PREP} in soundwire subsytem and remove the local SDW_REG_SHIFT(). This makes code IMO look much neater Tested this on db845c board Bard, can you please verify this on intel boards. Vinod Koul (9): soundwire: define and use addr bit masks soundwire: bus: use FIELD_GET() soundwire: slave: use SDW_DISCO_LINK_ID() soundwire: stream: use FIELD_{GET|PREP} soundwire: qcom : use FIELD_{GET|PREP} soundwire: cadence: use FIELD_{GET|PREP} soundwire: intel: use FIELD_{GET|PREP} soundwire: intel_init: use FIELD_{GET|PREP} soundwire: remove SDW_REG_SHIFT() drivers/soundwire/bus.c | 6 +-- drivers/soundwire/cadence_master.c | 53 ++++++++++--------------- drivers/soundwire/intel.c | 40 +++++++------------ drivers/soundwire/intel_init.c | 2 +- drivers/soundwire/qcom.c | 22 ++++------ drivers/soundwire/slave.c | 2 +- drivers/soundwire/stream.c | 13 +++--- include/linux/soundwire/sdw.h | 21 ++++++---- include/linux/soundwire/sdw_registers.h | 7 ---- 9 files changed, 67 insertions(+), 99 deletions(-)