| Message ID | 20200905173905.16541-1-jonathan@marek.ca (mailing list archive) |
|---|---|
| Headers | show |
| Series | soundwire: qcom: add support for mmio soundwire master | expand |
On 05/09/2020 18:39, Jonathan Marek wrote: > This adds initial support for soundwire device on sm8250. > > Tested with the "wsa" sdw device, which is simpler than the others. > > v2 addresses some feedback, but I kept this series as simple as possible. > In particular, I didn't implement CMD_NACKED from FIFO_STATUS, because > the downstream driver doesn't define this bit, so I can't implement it. > Soundwire works without it and It shouldn't be difficult to implement later. > > Jonathan Marek (4): > soundwire: qcom: fix abh/ahb typo > soundwire: qcom: avoid dependency on CONFIG_SLIMBUS > soundwire: qcom: add support for mmio soundwire master devices > soundwire: qcom: add v1.5.1 compatible > Hi Jonathan, I have tested these patches on RB5 with WSA8810 and they work fine. I can try to add support to command ignored in future, but for now these look good to me! Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Thanks, srini > .../bindings/soundwire/qcom,sdw.txt | 1 + > drivers/soundwire/Kconfig | 2 +- > drivers/soundwire/qcom.c | 38 +++++++++++++++++-- > 3 files changed, 36 insertions(+), 5 deletions(-) >
On 05-09-20, 13:39, Jonathan Marek wrote: > This adds initial support for soundwire device on sm8250. > > Tested with the "wsa" sdw device, which is simpler than the others. > > v2 addresses some feedback, but I kept this series as simple as possible. > In particular, I didn't implement CMD_NACKED from FIFO_STATUS, because > the downstream driver doesn't define this bit, so I can't implement it. > Soundwire works without it and It shouldn't be difficult to implement later. Applied all, thanks