[00/41] USB audio refactoring for better implicit feedback support

Message

Takashi Iwai Nov. 23, 2020, 8:53 a.m. UTC

Hi,

here is a largish patch set for USB-audio.  Its main goal is to
address the long-standing issues wrt the implicit feedback mode.
With the current driver, when the implicit fb is used, the full duplex
doesn't work properly unless you start both streams *very* carefully.
This patch set tries to ease such the configuration mismatch and fix
many other bugs.

In short, with this patch set applied, USB-audio driver will try to
restrict the hw_params to match with the already opened counter-part
stream automatically.  So individual aplay and arecord invocation
should work now, as well as PulseAudio.

Also, the patch set includes more fixes, e.g. the generic detection of
the implicit feedback mode on UAC2/3, and the fix for the sample rate
selection on UAC2/3, as well as a few more quirks to follow the new
implicit fb model.

The latest patches are available in topic/usb-audio-refactoring
branch.

I specially thank Keith Milner and Dylan Robinson for their time spent
for lots of testing.  Without their patient help, I couldn't finish
those patches, as I myself don't own such devices.


Takashi

===

Dylan Robinson (1):
  ALSA: usb-audio: Fix MOTU M-Series quirks

Takashi Iwai (40):
  ALSA: usb-audio: Handle discrete rates properly in hw constraints
  ALSA: usb-audio: Don't call usb_set_interface() at trigger callback
  ALSA: usb-audio: Check valid altsetting at parsing rates for UAC2/3
  ALSA: usb-audio: Check implicit feedback EP generically for UAC2
  ALSA: usb-audio: Add snd_usb_get_endpoint() helper
  ALSA: usb-audio: Set and clear sync EP link properly
  ALSA: usb-audio: Improve some debug prints
  ALSA: usb-audio: Track implicit fb sync endpoint in audioformat list
  ALSA: usb-audio: Move snd_usb_autoresume() call out of setup_hw_info()
  ALSA: usb-audio: Add hw constraint for implicit fb sync
  ALSA: usb-audio: Simplify hw_params rules
  ALSA: usb-audio: Drop debug.h
  ALSA: usb-audio: Avoid doubly initialization for implicit fb
  ALSA: usb-audio: Create endpoint objects at parsing phase
  ALSA: usb-audio: Drop keep_interface flag again
  ALSA: usb-audio: Add snd_usb_get_host_interface() helper
  ALSA: usb-audio: Don't set altsetting before initializing sample rate
  ALSA: usb-audio: Pass snd_usb_audio object to quirk functions
  ALSA: usb-audio: Simplify snd_usb_init_sample_rate() arguments
  ALSA: usb-audio: Simplify snd_usb_init_pitch() arguments
  ALSA: usb-audio: Stop both endpoints properly at error
  ALSA: usb-audio: Set callbacks via snd_usb_endpoint_set_callback()
  ALSA: usb-audio: Always set up the parameters after resume
  ALSA: usb-audio: Fix EP matching for continuous rates
  ALSA: usb-audio: Refactor endpoint management
  ALSA: usb-audio: Fix possible stall of implicit fb packet ring-buffer
  ALSA: usb-audio: Constify audioformat pointer references
  ALSA: usb-audio: Use atomic_t for endpoint use_count
  ALSA: usb-audio: Refactoring endpoint URB deactivation
  ALSA: usb-audio: Drop unneeded snd_usb_substream fields
  ALSA: usb-audio: Unify the code for the next packet size calculation
  ALSA: usb-audio: Simplify rate_min/max and rates set up
  ALSA: usb-audio: Replace slave/master terms
  ALSA: usb-audio: Use unsigned char for iface and altsettings fields
  ALSA: usb-audio: Show sync endpoint information in proc outputs
  ALSA: usb-audio: Quirk for BOSS GT-001
  ALSA: usb-audio: Factor out the implicit feedback quirk code
  ALSA: usb-audio: Add generic implicit fb parsing
  ALSA: usb-audio: Add implicit_fb module option
  ALSA: usb-audio: Fix quirks for other BOSS devices

 Documentation/sound/alsa-configuration.rst |    5 +
 sound/usb/Makefile                         |    1 +
 sound/usb/card.c                           |   14 +-
 sound/usb/card.h                           |   53 +-
 sound/usb/clock.c                          |  152 ++--
 sound/usb/clock.h                          |   11 +-
 sound/usb/debug.h                          |   16 -
 sound/usb/endpoint.c                       |  943 +++++++++++++----------
 sound/usb/endpoint.h                       |   57 +-
 sound/usb/format.c                         |  125 +++-
 sound/usb/helper.c                         |   10 +
 sound/usb/helper.h                         |    3 +
 sound/usb/implicit.c                       |  402 ++++++++++
 sound/usb/implicit.h                       |   14 +
 sound/usb/mixer.c                          |   46 --
 sound/usb/pcm.c                            | 1117 ++++++++++------------------
 sound/usb/pcm.h                            |    7 +-
 sound/usb/proc.c                           |   35 +-
 sound/usb/quirks-table.h                   |    8 -
 sound/usb/quirks.c                         |   60 +-
 sound/usb/quirks.h                         |   10 +-
 sound/usb/stream.c                         |   24 +-
 sound/usb/usbaudio.h                       |    5 +-
 23 files changed, 1696 insertions(+), 1422 deletions(-)
 delete mode 100644 sound/usb/debug.h
 create mode 100644 sound/usb/implicit.c
 create mode 100644 sound/usb/implicit.h