mbox series

[0/2] ASoC: qcom: Fix broken lpass driver

Message ID 20210118164509.32307-1-srinivas.kandagatla@linaro.org (mailing list archive)
Headers show
Series ASoC: qcom: Fix broken lpass driver | expand

Message

Srinivas Kandagatla Jan. 18, 2021, 4:45 p.m. UTC
LPASS driver is partially broken on DragonBoard DB410c on 5.10 and
its totally broken on other Supported Qualcomm SoCs.

This was due to DAI ids being over written by the SoC specific header files
in the dt-bindings.

Idea of having SoC specific headers is not doable when we are dealing with
a common driver. So this patchset attempts to fix this properly by creating
a common dt-bindings header for lpass which can be updated with new entries
if required. This patchset also add an simple of_xlate function to resolve
the dai names and different SoCs might not have 1:1 mapping for the
dai_driver array with dai ids.

Srinivas Kandagatla (2):
  ASoC: dt-bindings: lpass: Fix and common up lpass dai ids
  ASoC: qcom: Fix broken support to MI2S TERTIARY and QUATERNARY

 include/dt-bindings/sound/apq8016-lpass.h |  7 +++----
 include/dt-bindings/sound/qcom,lpass.h    | 15 +++++++++++++++
 include/dt-bindings/sound/sc7180-lpass.h  |  6 ++----
 sound/soc/qcom/lpass-cpu.c                | 22 ++++++++++++++++++++++
 sound/soc/qcom/lpass-platform.c           | 12 ++++++++++++
 sound/soc/qcom/lpass-sc7180.c             |  6 +++---
 sound/soc/qcom/lpass.h                    |  2 +-
 7 files changed, 58 insertions(+), 12 deletions(-)
 create mode 100644 include/dt-bindings/sound/qcom,lpass.h

Comments

Mark Brown Jan. 21, 2021, 12:05 a.m. UTC | #1
On Mon, 18 Jan 2021 16:45:07 +0000, Srinivas Kandagatla wrote:
> LPASS driver is partially broken on DragonBoard DB410c on 5.10 and
> its totally broken on other Supported Qualcomm SoCs.
> 
> This was due to DAI ids being over written by the SoC specific header files
> in the dt-bindings.
> 
> Idea of having SoC specific headers is not doable when we are dealing with
> a common driver. So this patchset attempts to fix this properly by creating
> a common dt-bindings header for lpass which can be updated with new entries
> if required. This patchset also add an simple of_xlate function to resolve
> the dai names and different SoCs might not have 1:1 mapping for the
> dai_driver array with dai ids.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: lpass: Fix and common up lpass dai ids
      commit: 09a4f6f5d21cb1f2633f4e8b893336b60eee9a01
[2/2] ASoC: qcom: Fix broken support to MI2S TERTIARY and QUATERNARY
      commit: cd3484f7f1386071b1af159023917ed12c182d39

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark